From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56643: 29.0.50; Help-mode bookmarks not loading with native compilation Date: Fri, 22 Jul 2022 16:40:14 +0300 Message-ID: <83wnc5jmf5.fsf@gnu.org> References: <83k089m4j0.fsf@gnu.org> <8335ewm2i1.fsf@gnu.org> <83a693lhms.fsf@gnu.org> <87sfmvtn99.fsf@web.de> <838ronkpzh.fsf@gnu.org> <83y1wmmyq7.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26142"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, defun.foo@proton.me, 56643@debbugs.gnu.org To: akrl@sdf.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 22 15:41:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oEsuR-0006fO-0m for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Jul 2022 15:41:39 +0200 Original-Received: from localhost ([::1]:47242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEsuP-0002Zs-Vp for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Jul 2022 09:41:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEstq-0002Z9-Fi for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2022 09:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50702) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oEstq-0003qi-6L for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2022 09:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oEstp-0003ne-UH for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2022 09:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Jul 2022 13:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56643 X-GNU-PR-Package: emacs Original-Received: via spool by 56643-submit@debbugs.gnu.org id=B56643.165849722614549 (code B ref 56643); Fri, 22 Jul 2022 13:41:01 +0000 Original-Received: (at 56643) by debbugs.gnu.org; 22 Jul 2022 13:40:26 +0000 Original-Received: from localhost ([127.0.0.1]:40451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEstF-0003ma-Q9 for submit@debbugs.gnu.org; Fri, 22 Jul 2022 09:40:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oEstE-0003mD-3Q for 56643@debbugs.gnu.org; Fri, 22 Jul 2022 09:40:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43708) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEst8-0003Y4-Eh; Fri, 22 Jul 2022 09:40:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HKJ/BlsAgxdBR4ZSo6IpSlpUspyEz9+cgC+bezcWFJU=; b=Uhf/ssJqkw0E hZ2gHIbKYdXSoDFtUlOstqcCo7Xv3VWP4Q0aQTArp0gEuwQTQG5oDPBZj0CnxcaJpw19HVp1M5X/P 8/srOlrtHI7vpDt3r8YLJBXFw/naqc/Fkvr3qCU7doXiFYdZrrE5Fis0+hUbosFkM+pblQ4/dbO7J pIM/baJvZ1eFSIj8IMK0HValSbR+u2VhDgSii+QV+mMXAMwUK7tp3SOZTZpHAnAlVJ63x6qiqIXcd cZkBLmx0YCBgU9OzUt13drmPYX9NJToVo3jKnqBX1HLBxj7uwslxb4K2xypBjS5dtGVMFn3k2qk/v JTyViF1IxKks7RQNPXa/SA==; Original-Received: from [87.69.77.57] (port=3727 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEst7-0003Dn-T0; Fri, 22 Jul 2022 09:40:18 -0400 In-Reply-To: <83y1wmmyq7.fsf@gnu.org> (message from Eli Zaretskii on Thu, 21 Jul 2022 15:33:52 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237624 Archived-At: > Cc: michael_heerdegen@web.de, 56643@debbugs.gnu.org, akrl@sdf.org > Date: Thu, 21 Jul 2022 15:33:52 +0300 > From: Eli Zaretskii > > > > > Alternatively we could introduce a named helper function. Note there > > > > are more calls of `help-setup-xref' using lambdas in arguments. > > > > > > > > > And that would solve the problem? Did you try that? > > > > I tried it with describe-function and it does solve the problem, although as noted above there are many other functions that generate help buffers and pass in a lambda. > > I know very well there are other instances, I just wanted us to stay > focused. > > > Named helper: > > > > (defun describe-function-xref-func (function buffer) > > (let ((describe-function-orig-buffer > > (if (buffer-live-p buffer) buffer))) > > (describe-function function))) > > > > Revised describe-function snippet: > > > > (help-setup-xref > > (list 'describe-function-xref-func function describe-function-orig-buffer) > > (called-interactively-p 'interactive)) > > > > This produces the following bookmark, which I confirmed still works after restarting Emacs: > > > > ("named-function-help-bookmark" > > (position . 1) > > (last-modified 25305 7198 806743 243000) > > (help-fn . describe-function-xref-func) > > (help-args completing-read "*scratch*") > > (position . 1) > > (handler . help-bookmark-jump)) > > Thanks. If Andrea confirms that this won't have any problems with > native-compilation, I will install such changes on the release branch > (since AFAIU this issue is a regression in Emacs 28). Andrea, could you please tell if using a named function there will fix the problem? Thanks.