From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#57386: 29.0.50; support make-symbolic-link without admin priviledge on Windows Date: Wed, 24 Aug 2022 21:26:50 +0300 Message-ID: <83wnax4hw5.fsf@gnu.org> References: <838rnd638m.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4567"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57386@debbugs.gnu.org To: =?UTF-8?Q?Ki=C3=AAn_?= =?UTF-8?Q?Nguy=E1=BB=85n?= Quang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 24 20:27:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQv5q-00014m-1G for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Aug 2022 20:27:10 +0200 Original-Received: from localhost ([::1]:47834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQv5o-0002dx-TF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Aug 2022 14:27:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQv5i-0002dm-PJ for bug-gnu-emacs@gnu.org; Wed, 24 Aug 2022 14:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58453) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQv5i-00046G-Ag for bug-gnu-emacs@gnu.org; Wed, 24 Aug 2022 14:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oQv5i-0005EB-6c for bug-gnu-emacs@gnu.org; Wed, 24 Aug 2022 14:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Aug 2022 18:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57386 X-GNU-PR-Package: emacs Original-Received: via spool by 57386-submit@debbugs.gnu.org id=B57386.166136561620084 (code B ref 57386); Wed, 24 Aug 2022 18:27:02 +0000 Original-Received: (at 57386) by debbugs.gnu.org; 24 Aug 2022 18:26:56 +0000 Original-Received: from localhost ([127.0.0.1]:48202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQv5c-0005Dr-CE for submit@debbugs.gnu.org; Wed, 24 Aug 2022 14:26:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQv5T-0005DX-EY for 57386@debbugs.gnu.org; Wed, 24 Aug 2022 14:26:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49532) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQv5N-000456-Un; Wed, 24 Aug 2022 14:26:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=wQpNdvLR4M6yr70PoWtqFCcOCPiWnNxpekDcQU0fk8g=; b=DISyvkw/eiPt32qENI81 dhN13sBeGH0E649S6SeY2wQlGuKZ3XlESgCCrYIh37+vMvgiA0hxayRUqYYhB+v4zkwz2munHkH4v oGnRizo/M7bh5o4wH9zTfX9fqusXSiZEZFGVhOl4w7ouNtZh9L3gwZeJet4giy01V40DJUlgBE3tH bfjvPHyLFhARmQ3b1VAh7kVwb38FOs8pM9C8S3FjoClR0DlRKLZ12IC2doZ+Dpx1+3FkZk94MW0Wt mUnDj1JL9L2cXzI/KDFXlg/TpXubuR+z0963/PuA2mhwGEMWhLgGpqnThLHFW7XislfNpTuC74vUI jxeW1nfZBfbYeA==; Original-Received: from [87.69.77.57] (port=2929 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQv5N-0001Zg-Cv; Wed, 24 Aug 2022 14:26:41 -0400 In-Reply-To: (message from =?UTF-8?Q?Ki=C3=AAn_?= =?UTF-8?Q?Nguy=E1=BB=85n?= Quang on Thu, 25 Aug 2022 03:05:37 +0900) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240653 Archived-At: > From: Kiên Nguyễn Quang > Date: Thu, 25 Aug 2022 03:05:37 +0900 > Cc: 57386@debbugs.gnu.org > > You're right, there's a stupid check against parameters on the version that doesn't support the new flag. > Since from Windows 10, the Windows version checking is not recommended (and not accurate) anymore, I > think we can just retry if the function is called with invalid parameters. > That will probably slow down the down-level Windows versions, but the difference should not be too much. Unfortunately, invalid parameters could cause Emacs to abort, depending on how it was linked. So I still think checking the version of Windows is the way to go. That MS don't recommend that doesn't mean we must abide by their recommendations.