From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: xref-query-replace-in-results error message after xref-find-definitions, was: Re: bug#58158: 29.0.50; [overlay] Interval tree iteration considered harmful Date: Tue, 11 Oct 2022 14:51:12 +0300 Message-ID: <83wn96efyn.fsf@gnu.org> References: <83h70qhez0.fsf@gnu.org> <83edvuhaby.fsf@gnu.org> <831qruh67o.fsf@gnu.org> <83y1u2foli.fsf@gnu.org> <83zgehe6iq.fsf@gnu.org> <95113379-99d8-eba4-f980-a7fca11430d5@yandex.ru> <834jwfmn5a.fsf@gnu.org> <838rlohzeo.fsf@gnu.org> <83mta2g91p.fsf@gnu.org> <237a3e26-03b8-a2a9-90bd-d50c3670a131@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7305"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 11 15:36:03 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oiFQQ-0001ee-L5 for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 15:36:02 +0200 Original-Received: from localhost ([::1]:44754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiFQO-0003aB-OF for ged-emacs-devel@m.gmane-mx.org; Tue, 11 Oct 2022 09:36:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiDms-0006Rd-F4 for emacs-devel@gnu.org; Tue, 11 Oct 2022 07:51:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54904) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiDmq-0008EF-ME; Tue, 11 Oct 2022 07:51:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lzJZFpxtjgX4aA4GWzAf4l8CRUcxVZuffh+S4uBgChM=; b=LYOPlfGXeY4I Zxh+eVWABetHww9X0kqJmsfBxX3RvsTBcDeI7HdTFkJxGcJB9UGGx2oAWa6VjEOhAc2xfGeIvpytU JPgiesglsJCJ/yKXucuc/JowBoemsQC7jcT/gSaOKbeRSaJiwRfEIX67CBUl0d0V2P8+5S1k1KPmt Zbk1jOxqYt4zZJyQ3GFE/DtQnZMKYvjyAlHKcd/TwNDxsa9U8AxU9sdyBhvib4oJQSqMsUe0cxHqH jdNr+B3mRNKZCVqQt19n7W0m3iJi/jK5En89m2+GZA9V+ag8aSdgzidRiwBpPwHgHLn75YvGLnEwy 7QY0cvQLRkb4XO9ABxgUsw==; Original-Received: from [87.69.77.57] (port=4627 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiDmq-00025n-50; Tue, 11 Oct 2022 07:51:04 -0400 In-Reply-To: <237a3e26-03b8-a2a9-90bd-d50c3670a131@yandex.ru> (message from Dmitry Gutov on Tue, 11 Oct 2022 14:36:11 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297479 Archived-At: > Date: Tue, 11 Oct 2022 14:36:11 +0300 > Cc: emacs-devel > From: Dmitry Gutov > > Moving from Debbugs here. > > On 11.10.2022 09:37, Eli Zaretskii wrote: > >> Date: Tue, 11 Oct 2022 05:12:11 +0300 > >> Cc: gerd.moellmann@gmail.com, 58158@debbugs.gnu.org, monnier@iro.umontreal.ca > >> From: Dmitry Gutov > >> > >> What is a "subset of matches"? > > > > Feel free to suggest a less vague description. The idea is that the > > list in Xref buffer doesn't show all the references to the identifier, > > making renaming infeasible. > > How about: > > Cannot perform replacements in this search's results This is similar to the original message. Its problem is that it states the fact, but doesn't attempt to explain it, and thus doesn't give a clue what the user did wrong and how to fix that. > > More generally, what exactly does xref.el test to produce the error > > message, and how to describe that in user-level terms? > > It tests whether the method xref-match-length returns non-nil for any > search results. When they do, it would identify them as "match xrefs" > (mentioned in the Commentary). > > But I suppose that clashes with the terminology you prefer to use. If it's possible to come up with the semantics of xref-match-length or of "match xrefs", maybe that could be useful. The commentary just says the "correspond to search result", which is not very useful for this purpose. > > You are saying that 'r' is only useful after M-?, is that right? The > > manual says so, but the manual doesn't have to say "the whole truth". > > The doc string should. > > It works after dired-do-find-regexp and project-find-regexp as well. So wed cannot say something like "This can only be used after M-?", sigh... I still have no idea how to improve the error message.