From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: xref-query-replace-in-results error message after xref-find-definitions, was: Re: bug#58158: 29.0.50; [overlay] Interval tree iteration considered harmful Date: Wed, 12 Oct 2022 17:05:15 +0300 Message-ID: <83wn95b0is.fsf@gnu.org> References: <831qruh67o.fsf@gnu.org> <83y1u2foli.fsf@gnu.org> <83zgehe6iq.fsf@gnu.org> <95113379-99d8-eba4-f980-a7fca11430d5@yandex.ru> <834jwfmn5a.fsf@gnu.org> <838rlohzeo.fsf@gnu.org> <83mta2g91p.fsf@gnu.org> <237a3e26-03b8-a2a9-90bd-d50c3670a131@yandex.ru> <83wn96efyn.fsf@gnu.org> <5bb803bf-f51b-c175-f908-c60066d6967d@yandex.ru> <83v8oqeeqf.fsf@gnu.org> <7c0849be-145e-e073-49b5-63749e8d8282@yandex.ru> <83sfjuecyw.fsf@gnu.org> <83k056e4dz.fsf@gnu.org> <83h70ae23f.fsf@gnu.org> <21c2aec6-ee5e-c794-de3c-808356e72eb9@yandex.ru> <831qrdei3t.fsf@gnu.org> <3ca55cea-712b-2e89-cdac-3a1893e3c53e@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7176"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 12 16:07:38 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oicOY-0001iP-7a for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Oct 2022 16:07:38 +0200 Original-Received: from localhost ([::1]:33428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oicOW-0001Hm-V5 for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Oct 2022 10:07:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oicM4-0007Sq-Jn for emacs-devel@gnu.org; Wed, 12 Oct 2022 10:05:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36018) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oicM4-0001NL-BE; Wed, 12 Oct 2022 10:05:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lC0xSzSP/dIbCv4vVaEjtFujcdimcRKjhVr9Ll5R9ss=; b=c87C6PSJlgTA LnGwZxUirGAs7Mvkef6MYOw0lRQVjV//BiVNWogZ7HCjQnRHwoNe5UEMV2pkkjo38Jpu+CKdEmB2U kGcz5bVMXyvVP3maUY5UwguO6azjcHACM/7ndAl5CvtOcj3V/NlCBFB1Msb1OLKnhZbyLWWxrzRyc OgDteireUHpzNVh8LW+Hr5ff4qDO0kPUHRlxQp9RttJGLQ1m6g9sE15EsaR6okUu+gqlGpVLBHikr hwAwU/wr4SaXX5GhHcgi6tOJKWYAtJFOI2ydGpiFCmMiUNjQedId8NfMDkq29w2Lw7vAeMfAwU2C6 S5hPnhSOL/6TNy1pBEXdJw==; Original-Received: from [87.69.77.57] (port=2915 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oicM2-0006YH-Iu; Wed, 12 Oct 2022 10:05:04 -0400 In-Reply-To: <3ca55cea-712b-2e89-cdac-3a1893e3c53e@yandex.ru> (message from Dmitry Gutov on Wed, 12 Oct 2022 16:47:15 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297613 Archived-At: > Date: Wed, 12 Oct 2022 16:47:15 +0300 > Cc: emacs-devel@gnu.org > From: Dmitry Gutov > > On 12.10.2022 08:17, Eli Zaretskii wrote: > >> Let's drop the "global" adjective, though: whether the command works > >> "globally", "locally", or etc, depends on how the user made the search. > > The "global" part is important, though: it's supposed to hint on why > > find-definition results cannot be used. The opposite of "global" here > > is "partial", not "local". If you can suggest a better word for > > "global" here, please do. > > I think you're trying hard to make it clearer, but it still won't have > 100% the intended effect. > > And it makes the error more likely to confuse the user and make them > misunderstand how things work: > > 1) Saying "Cannot perform global replacement in find-definition > results", with the explicit qualifier "global", potentially implies that > a "local" replacement in find-definition results can be done. But it > cannot. We can't do either currently for technical reasons. > > We don't want to do "local" replacements in find-definition results also > for logical reasons, but that's just the reason why we're not in a hurry > to remove the technical limitation. > > 2) The message implies 'r' is limited to "global" replacement. But it > can easily do "partial" replacement, as long as the command that > produces the list returns "match xrefs". dired-do-find-regexp, for > example. Or project-find-regexp, when called with C-u, and the user > specifies a specific directory. They will return a "partial" list of > matches, compared to the full project search. Sorry, I'm unconvinced. AFAICT, you are reiterating issues and arguments we already have been through.