From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58864: 29.0.50; Warning when compiling emacs-lisp/hierarchy.el Date: Sun, 30 Oct 2022 10:05:14 +0200 Message-ID: <83wn8hg2it.fsf@gnu.org> References: <86k04ion7u.fsf@gnu.org> <8335b6iyrr.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9517"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58864@debbugs.gnu.org, arash@gnu.org To: Jaft Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 30 09:06:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1op3Kp-0002I8-8E for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Oct 2022 09:06:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1op3KW-0000Q0-4O; Sun, 30 Oct 2022 04:06:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op3KU-0000Pp-PS for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 04:06:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1op3KU-0006Zo-9n for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 04:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1op3KT-00040z-QI for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 04:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Oct 2022 08:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58864 X-GNU-PR-Package: emacs Original-Received: via spool by 58864-submit@debbugs.gnu.org id=B58864.166711715015406 (code B ref 58864); Sun, 30 Oct 2022 08:06:01 +0000 Original-Received: (at 58864) by debbugs.gnu.org; 30 Oct 2022 08:05:50 +0000 Original-Received: from localhost ([127.0.0.1]:37270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op3KE-00040J-Ej for submit@debbugs.gnu.org; Sun, 30 Oct 2022 04:05:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op3K9-0003zx-Lh for 58864@debbugs.gnu.org; Sun, 30 Oct 2022 04:05:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op3K2-0006Yz-S8; Sun, 30 Oct 2022 04:05:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ojp91h1GRxt5JGOHEFPM29HXIw/5rd7ABYtFOcMwtfo=; b=IRoCpt9ytrsH YGI53hpqYRRavgQn+R4h03NNLOd7m1t4CBC79ZLeXAmyLGlKmDsIAosiHsGPAc3Pq6zNV+EhnI0Hy tSWQarOQxNxfQqlvgQrN7fuF+q1mI0EPC510QED+1rr/ZpqgD8NwXHNiyTyJjqHm1HGNNBVozkyv0 PeZVifdmLRoFyt/jZYZJbAzxHtuQVwEXIrTC2vPp3g7AJ63Ka3dNb7BwGKtotz4aa94dJ+6/Olg9d euDDtRWByY7E+9d2X61AHPPq7CL9A9Skz4H+4tQFqz6o/g62GXDZxt0Y8OaegOEDexT06p8lduujm lOs+vfg23pWbALPBHnk3fg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op3K2-00080s-5C; Sun, 30 Oct 2022 04:05:34 -0400 In-Reply-To: (message from Jaft on Sun, 30 Oct 2022 07:26:34 +0000 (UTC)) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246598 Archived-At: > Date: Sun, 30 Oct 2022 07:26:34 +0000 (UTC) > From: Jaft > Cc: "58864@debbugs.gnu.org" <58864@debbugs.gnu.org> > > I'm not sure why this warning occurs? Can you not have unused arguments (marked as unused) in lexical > scope? You can, but the argument should indeed be marked as unused, by prepending the '_' to its name. Basil already did that, so the problem is now solved. > hierarchy--create-delayed-tree-widget calls widget-convert to create tree-widgets but, in the case of delayed > children, provides an :expander to load when the child is called for; the :expander expects a function that can > take a single argument: the widget you're making children for. > I assume it's so your function can figure out what the children should be, depending on what the parent > widget is. > > However, Hierarchy already computes the children with the childrenfn a user can pass in so the parent widget > is entirely unnecessary for us; so I marked is as unused by prefacing the variable name with an underscore, > as I thought was the convention. This explanation should be best put in a comment to that function, I think.