From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: master ef14acf: Make nnml handle invalid non-ASCII headers more consistently Date: Mon, 19 Dec 2022 19:44:02 +0200 Message-ID: <83wn6ncmql.fsf@gnu.org> References: <20210122180801.14756.84264@vcs0.savannah.gnu.org> <20210122180802.F0A1E20A10@vcs0.savannah.gnu.org> <874jtvq8c2.fsf@oldenburg.str.redhat.com> <83k02qiicb.fsf@gnu.org> <87bko26ptd.fsf@oldenburg.str.redhat.com> <83r0wygh9b.fsf@gnu.org> <87k02nze8a.fsf@oldenburg.str.redhat.com> <83zgbjcoeq.fsf@gnu.org> <87k02nxq1e.fsf@oldenburg.str.redhat.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="695"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, eric@ericabrahamsen.net, emacs-devel@gnu.org, ding@gnus.org To: Florian Weimer Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 19 18:44:28 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7KBg-000AWK-3z for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Dec 2022 18:44:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7KB9-0002hK-99; Mon, 19 Dec 2022 12:43:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7KB7-0002h9-MF for emacs-devel@gnu.org; Mon, 19 Dec 2022 12:43:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7KB6-0007jY-Ud; Mon, 19 Dec 2022 12:43:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=U4NLXJ9AInSM6AIe5lc++pybQlyx2QjyzyOI0TntizI=; b=TkeT9RIXLdSn /pIAJX18sc4kgvvvRGUs0lgN+S7KEG9WXVvy9CD903ZHOZp3SGvcArFZGqNyXw8S/74kKbo62eoVS qjxmSyDJSHL0JobYFXIS2sYXNdwxafXCP+Rfoxl2jepkXvYA9ZU+5V8yQfm9thnF9h0QYapROIKPT RJWIseZnUXLNShD0p+sVL6a5ENL4APuwXVrIzm41NGeLSG76ej/7wpNetCz1N5whqFNi/r0InrdeC 79xKF2hn7ki5Com+3nd957ouZ4hC6iWsqggXsaL/Lmkyu1ducCnMSGZn7z0wXC1L5mk3qCsTn9P5C nwyb256TWmZcL+l8AJS5vg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7KB6-0001Kk-8o; Mon, 19 Dec 2022 12:43:52 -0500 In-Reply-To: <87k02nxq1e.fsf@oldenburg.str.redhat.com> (message from Florian Weimer on Mon, 19 Dec 2022 18:27:09 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301663 gmane.emacs.gnus.general:91038 Archived-At: > From: Florian Weimer > Cc: larsi@gnus.org, eric@ericabrahamsen.net, emacs-devel@gnu.org, > ding@gnus.org > Date: Mon, 19 Dec 2022 18:27:09 +0100 > > * Eli Zaretskii: > > >> As I expected, I could reproduce the issue with new mail. I'm happy to > >> report that replacing nnml--encode-headers with your new version fixes > >> the issue. > > > > Thanks, so I've now installed this on the emacs-29 branch, for the > > upcoming Emacs 29.1. > > It's a denial-of-service issue, so it should be backported to 28 if > possible, too. We don't plan on any more releases from the emacs-28 branch. I guess distros will do the backporting, though. > >> I assume that there is some protection in place that tabs are not > >> possible here? > > > > Tabs where, and what kind of protection are we talking about? > > The .overview file is in tab-separated-values format, and I think the > code is supposed to replace tabs with spaces before the lines are > written. But mail-encode-encoded-word-string/rfc2047-encode-string > generally does not replace tabs, so your change shouldn't make things > worse at least. OK, thanks.