From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 60942@debbugs.gnu.org
Subject: bug#60942: 30.0.50; [PATCH] Indices in Eshell variable interpolation don't work with async subcommands
Date: Thu, 19 Jan 2023 08:49:34 +0200 [thread overview]
Message-ID: <83wn5jyq69.fsf@gnu.org> (raw)
In-Reply-To: <20e5cb2f-aabe-53fd-d3af-81ec5ff11e7b@gmail.com> (message from Jim Porter on Wed, 18 Jan 2023 19:36:41 -0800)
> Date: Wed, 18 Jan 2023 19:36:41 -0800
> From: Jim Porter <jporterbugs@gmail.com>
>
> Starting from "emacs -Q -f eshell":
>
> ~ $ echo $exec-path[0]
> /usr/local/sbin
> ~ $ echo $exec-path[${echo 0}]
> /usr/local/sbin
> ~ $ echo $exec-path[${*echo 0}]
> ;; no output
>
> This is because 'eshell-eval-indices' gets an S-expr describing code to
> evaluate for the indices, and it just passes that to 'eval'. That's not
> the right way to do things for Eshell: instead, we should rely on
> 'eshell-do-eval', which properly handles asynchronous evaluation. That's
> required for working with external commands like "*echo" (which calls
> the real /bin/echo).
>
> The attached patch fixes this by changing 'eshell-eval-indices' to
> 'eshell-indices', which does some minimal transformations on the S-expr
> for the indices, and then uses it to build the final S-expr to pass to
> 'eshell-do-eval'.
>
> This could possibly go in Emacs 29, since it's a bugfix to add onto a
> previous bugfix (see commit 990f36fa10). However, I'd lean towards just
> merging to master; this is a fairly obscure issue, and we can't just fix
> *every* bug we find on the release branch, or the branch will never
> stabilize. If someone else thinks it's important enough to go on the
> release branch though, I won't argue.
Why do you remove a non-internal function? We cannot possibly do that
if this is going to be installed on the emacs-29 branch. But even if
you are going to install on master, why not leave that function alone?
Some code somewhere could be using it, and we don't usually remove
functions before a period of deprecation.
next prev parent reply other threads:[~2023-01-19 6:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 3:36 bug#60942: 30.0.50; [PATCH] Indices in Eshell variable interpolation don't work with async subcommands Jim Porter
2023-01-19 6:49 ` Eli Zaretskii [this message]
2023-01-19 7:37 ` Jim Porter
2023-01-19 19:31 ` Jim Porter
2023-01-19 19:41 ` Eli Zaretskii
2023-01-19 20:20 ` Jim Porter
2023-01-20 1:54 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wn5jyq69.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60942@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.