From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61155: 29.0.60; build failures tree sitter Date: Mon, 30 Jan 2023 16:20:38 +0200 Message-ID: <83wn543xzd.fsf@gnu.org> References: <7581-Sun29Jan2023210007+0000-jpff@codemist.co.uk> <877cx4z7lz.fsf@gmail.com> <87cz6w1c93.fsf@thornhill.no> <834js85fhe.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16408"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rpluim@gmail.com, 61155@debbugs.gnu.org, jpff@codemist.co.uk To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 30 15:21:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMV2A-0003q2-2H for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Jan 2023 15:21:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMV1r-0005Lf-0s; Mon, 30 Jan 2023 09:21:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMV1q-0005LT-0i for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 09:21:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMV1p-0001uH-PN for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 09:21:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMV1p-0002HY-Lh for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 09:21:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jan 2023 14:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61155 X-GNU-PR-Package: emacs Original-Received: via spool by 61155-submit@debbugs.gnu.org id=B61155.16750884538736 (code B ref 61155); Mon, 30 Jan 2023 14:21:01 +0000 Original-Received: (at 61155) by debbugs.gnu.org; 30 Jan 2023 14:20:53 +0000 Original-Received: from localhost ([127.0.0.1]:46768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMV1g-0002Gp-Qd for submit@debbugs.gnu.org; Mon, 30 Jan 2023 09:20:53 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMV1f-0002GY-8c for 61155@debbugs.gnu.org; Mon, 30 Jan 2023 09:20:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMV1Z-0001rF-Nm; Mon, 30 Jan 2023 09:20:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wZpjSA+MteI1dl3vvz2dTYa5QXuao7AWVAvLOmuvAWQ=; b=YPOH8b+0ER2D 8uoq9Wj4jPro7aRIY2mkg+y7i14UBikGesdMxAtqLnxw3BG91BzR9kuZ/A8O5objz7p/ZqPXao758 N+WWyBjeKqUq36TsgohahH50nP1yl16SNTkkUy7Mz4cxeHf8hdu2YjKyNmbVTNtce4jApCYNcoV9D Xtnf6JQhavYBdimjlnBsIZbjJnCoDHbJkGObDBrGHFmZyadqpdsnG3jTyjs9KnZNuTtXbpGRjuQz+ GA0lx0VR4VXgEEjjqXfoHAsUA0sJZ44sJX32Cdd8il8UyzecbqBRzmxDKih1/icPjv1W83XDw0uS0 bSioBjsDWS0S2IbLtKSILA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMV1Z-00088G-71; Mon, 30 Jan 2023 09:20:45 -0500 In-Reply-To: (message from Theodor Thornhill on Mon, 30 Jan 2023 14:22:10 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254428 Archived-At: > Date: Mon, 30 Jan 2023 14:22:10 +0100 > From: Theodor Thornhill > CC: rpluim@gmail.com, jpff@codemist.co.uk, 61155@debbugs.gnu.org > > > > On 30 January 2023 14:17:17 CET, Eli Zaretskii wrote: > >> Cc: 61155@debbugs.gnu.org > >> Date: Mon, 30 Jan 2023 12:40:40 +0100 > >> From: Theodor Thornhill via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> Can you try this and see if the error goes away? > >> > >> thanks, > >> Theo > >> > >> diff --git a/lisp/treesit.el b/lisp/treesit.el > >> index 92833fb007..d7e702bfb8 100644 > >> --- a/lisp/treesit.el > >> +++ b/lisp/treesit.el > >> @@ -568,7 +568,7 @@ treesit--font-lock-level-setter > >> res) > >> (let ((buffer (car buffers))) > >> (with-current-buffer buffer > >> - (if (treesit-parser-list) > >> + (if (and (treesit-available-p) (treesit-parser-list)) > >> (loop (append res (list buffer)) (cdr buffers)) > >> (loop res (cdr buffers)))))))) > > > >I fixed this differently, please see the latest emacs-29 branch: I > >disabled the loop altogether. > > > >Why would we need to loop over buffers if tree-sitter is not > >available? > > No need, your fix it fine, i just whipped up something quick in a break here :) OK, thanks. Btw, it was a bitch finding which code caused the error message. It is easy to forget that the :set functions of defcustom's are called during startup, and the line number shown with the message didn't identify the defcustom, just the file name. I eventually found this was the culprit by running the byte-compilation command under GDB...