From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63949: 30.0.50; =?UTF-8?Q?`vc-print-log=C2=B4?= does not erase buffer when called from *vc-change-log* buffer, at least for CVS logs Date: Fri, 09 Jun 2023 09:41:48 +0300 Message-ID: <83wn0d16j7.fsf@gnu.org> References: <8c62dd9a-3cad-b992-bfc4-64b2f1db4485@vodafonemail.de> <965f7636-1bac-02ff-e9f2-d6848aa2df4b@vodafonemail.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18359"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63949@debbugs.gnu.org To: Jens Schmidt Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 09 08:42:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7VpA-0004ZX-N5 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Jun 2023 08:42:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7Voy-0005zV-R6; Fri, 09 Jun 2023 02:42:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Vox-0005zK-GU for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2023 02:42:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7Vox-000195-6i for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2023 02:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q7Vow-0004j6-K2 for bug-gnu-emacs@gnu.org; Fri, 09 Jun 2023 02:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Jun 2023 06:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63949 X-GNU-PR-Package: emacs Original-Received: via spool by 63949-submit@debbugs.gnu.org id=B63949.168629291318150 (code B ref 63949); Fri, 09 Jun 2023 06:42:02 +0000 Original-Received: (at 63949) by debbugs.gnu.org; 9 Jun 2023 06:41:53 +0000 Original-Received: from localhost ([127.0.0.1]:58210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7Vom-0004ig-O8 for submit@debbugs.gnu.org; Fri, 09 Jun 2023 02:41:53 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7Voi-0004iQ-E0 for 63949@debbugs.gnu.org; Fri, 09 Jun 2023 02:41:51 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Vob-00016n-KY; Fri, 09 Jun 2023 02:41:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=akz8Iw9GaOnKtUSM150WHHySlLlshPWXUd3BSjZIAJU=; b=KmIWpBofGBGJR9HWW8b8 rnFnmps+WnaiRpIaBsxXK7p0L9HsDr2X7TUeZBcSJ6ULRF8oTs6dYKevuwAPyta6i+3gGupHFCBym p7sHPZD2Vt8VTEecMtn1Gypu7VAHjG9ZLhrzsiQyJ0RmlE1KIOogLfinbIk443yLjdT2fRSUc4kh5 6K+AUFIzRVXn7AtVoSBoEhCv82ERsgMFbAP4rqaa8alsR4qJpSJo0nWe8DlLoYerfm56qjjJmKYMl P4HEulPYi+8+QqRCHz1Lvp4s+xkKA04/e7zqaUX26gGcVcV9d+tqZxhwD0smdZ139/4quxai3ySSY E+rXtvcPCmo75g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7Vob-0007un-45; Fri, 09 Jun 2023 02:41:41 -0400 In-Reply-To: <965f7636-1bac-02ff-e9f2-d6848aa2df4b@vodafonemail.de> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263157 Archived-At: > Date: Fri, 9 Jun 2023 00:44:39 +0200 > From: Jens Schmidt via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Here come five patches for this issue, based on emacs-29: > > 0001-Always-erase-log-buffer-before-calling-vc-print-log.patch > 0002-Always-erase-log-buffer-before-calling-vc-print-log.patch > 0003-Always-erase-log-buffer-before-calling-vc-print-log.patch Please add comments there explaining the significance of the call to vc-setup-buffer and its effect, depending on what is the current buffer. > 0005-Avoid-setting-circular-vc-parent-buffer.patch > > This one fixes the issue related to VC parent buffer described in the > previous update. The "local" change seems to be logical (a buffer > should not be the VC parent buffer of itself), but I'm not quite sure > about any adverse "global" consequences. This code is very old, so at the very least we need to track its origin and understand why it was added, before discussing whether it should be removed. AFAICT, this code was introduced in commit 1a2f456b73bab4a711a51c8f84abf1d9f63a3b90, 30 years ago, and there's some explanation of the rationale in the log message. Thanks.