From: Eli Zaretskii <eliz@gnu.org>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: 64048@debbugs.gnu.org
Subject: bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled
Date: Tue, 13 Jun 2023 21:19:00 +0300 [thread overview]
Message-ID: <83wn07usx7.fsf@gnu.org> (raw)
In-Reply-To: <87352vs2g5.fsf@localhost> (message from Ihor Radchenko on Tue, 13 Jun 2023 17:21:30 +0000)
> From: Ihor Radchenko <yantar92@posteo.net>
> Cc: 64048@debbugs.gnu.org
> Date: Tue, 13 Jun 2023 17:21:30 +0000
>
> May I rephrase is as a feature request then?
> Like, please add `global-*-modes' customization for modes defined via `define-globalized-minor-mode'?
> Or, at least, add `global-display-line-numbers-modes' customization?
I'm not against such a feature, not at all. My objection was only to
the particular implementation that you suggested: we cannot suddenly
add a :predicate to a global mode where previously there wasn't one.
People who activate this global mode expect it to be active
everywhere, no questions asked.
> I recall multiple occasions when I tried hard to disable a global mode
> in some buffers, remembered that there is some special variable for it;
> just to find out that a specific global minor mode does not support it.
The usual way of enabling a mode selectively is to enable the
non-global variant of the mode in a mode hook. I'm sure you know it.
> And then we have non-standard variables like
> `dabbrev-ignored-buffer-modes', `hi-lock-exclude-modes',
> `which-func-modes' - all with different conventions.
>
> I can also tell you that a question about disabling global minor modes
> in some buffers re-surfaces regularly in reddit discussions and IRC.
>
> We even have FAQ entries like https://www.emacswiki.org/emacs/LineNumbers#h5o-10
> And the suggested solution is re-defunning "turn-on" function - do we
> really want to say that it is the way to go?
You are preaching to the choir, really. There's nothing wrong with
using :predicate when introducing a new globalized minor mode. I only
objected to doing that in a mode that exists for such a long time
without any conditions.
(Btw, I don't think I understand the use of :predicate which you
proposed: it isn't documented as accepting a function, only nil, t, or
a list of modes.)
next prev parent reply other threads:[~2023-06-13 18:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 14:33 bug#64048: 30.0.50; global-display-line-numbers-mode has no easy way to set modes where it is enabled Ihor Radchenko
2023-06-13 15:50 ` Eli Zaretskii
2023-06-13 16:09 ` Ihor Radchenko
2023-06-13 16:49 ` Eli Zaretskii
2023-06-13 17:21 ` Ihor Radchenko
2023-06-13 18:19 ` Eli Zaretskii [this message]
2023-06-13 19:36 ` Ihor Radchenko
2023-06-14 11:58 ` Eli Zaretskii
2023-06-14 12:48 ` Ihor Radchenko
2023-06-17 7:46 ` Eli Zaretskii
2023-06-17 18:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-17 18:58 ` Eli Zaretskii
2023-06-17 19:06 ` Ihor Radchenko
2023-06-17 19:04 ` Ihor Radchenko
2023-06-17 19:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wn07usx7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64048@debbugs.gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.