From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 64311@debbugs.gnu.org, vas@oneofus.la
Subject: bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers
Date: Tue, 04 Jul 2023 14:21:39 +0300 [thread overview]
Message-ID: <83wmzfly64.fsf@gnu.org> (raw)
In-Reply-To: <jwv4jmk5p6t.fsf-monnier+emacs@gnu.org> (bug-gnu-emacs@gnu.org)
> Cc: 64311@debbugs.gnu.org
> Date: Mon, 03 Jul 2023 23:32:49 -0400
> From: Stefan Monnier via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> > diff --git a/lisp/shell.el b/lisp/shell.el
> > index b74442f1961..39e12577280 100644
> > --- a/lisp/shell.el
> > +++ b/lisp/shell.el
> > @@ -346,10 +346,10 @@ shell-dirstack
> > "List of directories saved by pushd in this buffer's shell.
> > Thus, this does not include the shell's current directory.")
> >
> > -(defvaralias 'shell-dirtrack-mode 'shell-dirtrackp)
> > -
> > -(defvar shell-dirtrackp t
> > - "Non-nil in a shell buffer means directory tracking is enabled.")
> > +(define-obsolete-variable-alias 'shell-dirtrackp 'shell-dirtrack-mode
> > + "???"
> > + "Non-nil in a shell buffer means directory tracking is enabled.
> > +Use the minor mode variable `shell-dirtrack-mode' instead.")
>
> Indeed `shell-dirtrackp` should not be defvar'd.
> The above looks good to me.
It doesn't look good to me, for the reasons I explained in the
discussion. Do you see anything wrong with the alternative patch I
proposed instead?
prev parent reply other threads:[~2023-07-04 11:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 4:39 bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers Vladimir Sedach
2023-06-27 11:18 ` Eli Zaretskii
2023-06-27 14:09 ` Vladimir Sedach
2023-06-27 15:52 ` Eli Zaretskii
2023-06-28 0:07 ` Vladimir Sedach
2023-06-28 11:46 ` Eli Zaretskii
2023-06-28 16:43 ` Vladimir Sedach
2023-06-28 18:31 ` Eli Zaretskii
2023-06-28 20:14 ` Vladimir Sedach
2023-06-29 4:57 ` Eli Zaretskii
2023-06-29 16:26 ` Vladimir Sedach
2023-06-29 18:10 ` Eli Zaretskii
2023-06-29 19:24 ` Vladimir Sedach
2023-06-30 5:40 ` Eli Zaretskii
2023-06-30 16:47 ` Vladimir Sedach
2023-07-02 6:39 ` Eli Zaretskii
2023-07-03 17:03 ` Vladimir Sedach
2023-07-03 17:17 ` Eli Zaretskii
2023-07-04 14:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-04 16:05 ` Eli Zaretskii
2023-07-04 18:34 ` Vladimir Sedach
2023-07-04 20:36 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-04 22:27 ` Vladimir Sedach
2023-07-04 23:42 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-06 20:30 ` Vladimir Sedach
2023-07-08 8:30 ` Eli Zaretskii
2023-07-08 16:18 ` Vladimir Sedach
2023-07-08 16:31 ` Eli Zaretskii
2023-07-04 3:32 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-04 11:21 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wmzfly64.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64311@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=vas@oneofus.la \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.