From: Eli Zaretskii <eliz@gnu.org>
To: Joseph Turner <joseph@breatheoutbreathe.in>
Cc: jporterbugs@gmail.com, emacs-devel@gnu.org
Subject: Re: [PATCH] Make ispell localwords safe local variable
Date: Sat, 26 Aug 2023 11:10:59 +0300 [thread overview]
Message-ID: <83wmxikyuk.fsf@gnu.org> (raw)
In-Reply-To: <CCD7BF9D-8E4B-474B-8F3D-D23016E89C0A@breatheoutbreathe.in> (message from Joseph Turner on Wed, 16 Aug 2023 16:04:48 -0700)
> Date: Wed, 16 Aug 2023 16:04:48 -0700
> From: Joseph Turner <joseph@breatheoutbreathe.in>
> CC: emacs-devel@gnu.org
>
>
>
> On August 16, 2023 10:12:30 AM PDT, Jim Porter <jporterbugs@gmail.com> wrote:
> >On 8/16/2023 5:20 AM, Eli Zaretskii wrote:
> >>> From: Joseph Turner <joseph@breatheoutbreathe.in>
> >>> Cc: emacs-devel@gnu.org
> >>> Date: Tue, 15 Aug 2023 18:41:18 -0700
> >>>
> >>> I am not sure. Unless someone can be certain that ispell can safely
> >>> handle arbitrary strings, I think it's prudent to discard this patch.
> >>
> >> Does anyone else have an opinion about this?
> >
> >I'm not very familiar with how Emacs talks to ispell, but would the proposed change here be any less safe than the buffer-local "LocalWords" block?
>
> (which are sent to ispell without user confirmation)
It sounds like no one sees a problem with this change, so I've now
installed it on the master branch.
Thanks.
next prev parent reply other threads:[~2023-08-26 8:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 5:40 [PATCH] Make ispell localwords safe local variable Joseph Turner
2023-08-15 11:56 ` Eli Zaretskii
2023-08-16 1:41 ` Joseph Turner
2023-08-16 12:20 ` Eli Zaretskii
2023-08-16 17:12 ` Jim Porter
2023-08-16 23:04 ` Joseph Turner
2023-08-26 8:10 ` Eli Zaretskii [this message]
2023-12-01 6:56 ` Joseph Turner
2023-12-01 8:03 ` Eli Zaretskii
2023-12-01 8:24 ` Joseph Turner
2023-12-01 11:28 ` Eli Zaretskii
2023-08-17 2:00 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wmxikyuk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=joseph@breatheoutbreathe.in \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.