From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66806: 30.0.50; [PATCH] 'project-find-regexp' passes Git submodules to the search program Date: Sun, 29 Oct 2023 08:06:44 +0200 Message-ID: <83wmv6arnv.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30544"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 66806@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 29 07:07:51 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qwyxi-0007iW-Ny for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Oct 2023 07:07:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qwyxQ-0008Hf-PD; Sun, 29 Oct 2023 02:07:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qwyxO-0008Bu-Cz for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 02:07:30 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qwyxO-0002J3-23 for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 02:07:30 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qwyxu-0004Sa-1m for bug-gnu-emacs@gnu.org; Sun, 29 Oct 2023 02:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Oct 2023 06:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66806 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66806-submit@debbugs.gnu.org id=B66806.169855966317115 (code B ref 66806); Sun, 29 Oct 2023 06:08:02 +0000 Original-Received: (at 66806) by debbugs.gnu.org; 29 Oct 2023 06:07:43 +0000 Original-Received: from localhost ([127.0.0.1]:40249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwyxa-0004Rz-Qf for submit@debbugs.gnu.org; Sun, 29 Oct 2023 02:07:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qwyxY-0004Rf-3r for 66806@debbugs.gnu.org; Sun, 29 Oct 2023 02:07:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qwyww-0002Gr-7S; Sun, 29 Oct 2023 02:07:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=g7V7sFfrHI4rEkJUSGf/qawxaYEvUpYEWqgEgir4r2U=; b=L8sCbvGmSBsf 2tMX43p1muJMkX0N3DJ1aPq5J1fMJeP6M13wZB15OWEu13yurxss2qhyn1ZKqUWYNvnQRGupkP5aa fmRXCLDwFHouAbcL+mt0bN2jf2lPnjL9J9FaYTH0tQrm1d7PGH5gTWjqCv4iPZGvxZLyuekVe2GBm UHr5tgmx+og+TI4/mgJSIuQP5jPE9O/tlWx0cD6aqHxHvVsBKbDlRE2SUxGE+HQ63WppxtDgFsOQH OqqqrdhzShJBTfTTcYOl6uaWDJ3COFeiTU0WXBwwyjTQBUE7pCa7NecvCGSTJM0z9QW0ynvh0Y09Z zV4AFw+DZ5tIoz/k/zWxRw==; In-Reply-To: (message from Jim Porter on Sat, 28 Oct 2023 22:36:07 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273482 Archived-At: > Cc: dmitry@gutov.dev > Date: Sat, 28 Oct 2023 22:36:07 -0700 > From: Jim Porter > > --- a/lisp/progmodes/project.el > +++ b/lisp/progmodes/project.el > @@ -960,7 +960,8 @@ project-find-regexp > (default-directory (project-root pr)) > (files > (if (not current-prefix-arg) > - (project-files pr) > + ;; XXX: See the comment in project-query-replace-regexp. > + (cl-delete-if-not #'file-regular-p (project-files pr)) ^^^^^^^^^^^^^^^^ I think we want to prefer using seq.el functions, since seq.el is nowadays preloaded. Is there a good reason to use cl-delete-if-not here?