From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66825: last-coding-system-used in basic-save-buffer Date: Mon, 30 Oct 2023 14:15:08 +0200 Message-ID: <83wmv49uib.fsf@gnu.org> References: <86v8apv3m7.fsf_-_@mail.linkov.net> <8334xtb560.fsf@gnu.org> <86bkcgy1oc.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20406"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66825@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 30 13:16:51 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qxRCM-0005AC-PB for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Oct 2023 13:16:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qxRC8-0005A7-DX; Mon, 30 Oct 2023 08:16:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxRC6-00054f-I8 for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2023 08:16:34 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qxRC1-0005oZ-6Y for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2023 08:16:34 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qxRCX-0008Of-US for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2023 08:17:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Oct 2023 12:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66825 X-GNU-PR-Package: emacs Original-Received: via spool by 66825-submit@debbugs.gnu.org id=B66825.169866817632207 (code B ref 66825); Mon, 30 Oct 2023 12:17:01 +0000 Original-Received: (at 66825) by debbugs.gnu.org; 30 Oct 2023 12:16:16 +0000 Original-Received: from localhost ([127.0.0.1]:44460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxRBn-0008NP-Op for submit@debbugs.gnu.org; Mon, 30 Oct 2023 08:16:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qxRBh-0008N6-SF for 66825@debbugs.gnu.org; Mon, 30 Oct 2023 08:16:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qxRB1-0005dx-Rm; Mon, 30 Oct 2023 08:15:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JvQbHNShTwUcIXjjEXw6D8WMEsIBABOQ57XKi1ewm0U=; b=LxOINzu49GDq 2xXPn42vCfFeVrccq/klJzJrKBJgPN4OgSB6ewWhdVvVoFOEFPriGZVKB7RB1jAOoGWCSJfNUWwdP yAyY3w5/FlsHI1Eq6TKbFYiHgbn3qgGFkf2aO/rWkXgEkIVEvUXqGbXhA5NGDiDYGMyMzVojnpXls s7rBr6N5zPeB3pkoXBfgralE9FjFYURHb8fcW+vgfM8I+GrUhH4z8RJziMO9DbYNGfJaBPu/JDH4v AhRd4VCsURafQgxpwKErLXqqxlMZHaXXnhBsNCZnmAesQQj/nyoQ8oksM4GxUwgi6J7zCUPeTywjb z06zPCEd/MzJLV8GBpyBbw==; In-Reply-To: <86bkcgy1oc.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 30 Oct 2023 09:56:27 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273547 Archived-At: > From: Juri Linkov > Cc: 66825@debbugs.gnu.org > Date: Mon, 30 Oct 2023 09:56:27 +0200 > > I don't understand this alternative. The mode line updating > that uses 'project-mode-line-format' that unintentionally > changes 'last-coding-system-used' is called from this line > in 'basic-save-buffer-2': > > (write-region nil nil > buffer-file-name nil t buffer-file-truename) > > because this call in 'write_region' updates the mode line: > > message_with_string ((NUMBERP (append) > ? "Updated %s" > : ! NILP (append) > ? "Added to %s" > : "Wrote %s"), > visit_file, 1); How does message_with_string update the mode line? And why does last-coding-system-used get set to raw-text-unix in this scenario anyway? > + ;; Preserve the original value of 'last-coding-system-used' > + ;; that can break 'basic-save-buffer' (bug#66825) > + (let ((last-coding-system-used nil)) > + (concat > + " " > + (propertize > + (project-name project) > + 'face project-mode-line-face > + 'mouse-face 'mode-line-highlight > + 'help-echo "mouse-1: Project menu" > + 'local-map project-mode-line-map))))) I'm confused how this avoids the problem, probably because I don't understand the answers to the two questions above.