From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67658: filesets =?UTF-8?Q?can=E2=80=99t?= open files from menu-bar when using =?UTF-8?Q?=E2=80=98:tree=E2=80=99?= Date: Sat, 16 Dec 2023 13:33:17 +0200 Message-ID: <83wmtemlfm.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=gb2312 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23385"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67658@debbugs.gnu.org To: ". shynur" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 16 12:34:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rESw2-0005sy-CN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Dec 2023 12:34:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rESvj-0002ve-Gh; Sat, 16 Dec 2023 06:34:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rESvh-0002t4-Oz for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 06:34:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rESvh-0003Py-G9 for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 06:34:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rESvh-0000GM-Vp for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 06:34:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Dec 2023 11:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67658 X-GNU-PR-Package: emacs Original-Received: via spool by 67658-submit@debbugs.gnu.org id=B67658.1702726425977 (code B ref 67658); Sat, 16 Dec 2023 11:34:01 +0000 Original-Received: (at 67658) by debbugs.gnu.org; 16 Dec 2023 11:33:45 +0000 Original-Received: from localhost ([127.0.0.1]:54054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rESvR-0000Fh-Bt for submit@debbugs.gnu.org; Sat, 16 Dec 2023 06:33:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rESvO-0000FU-WA for 67658@debbugs.gnu.org; Sat, 16 Dec 2023 06:33:43 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rESvI-0003Oc-La; Sat, 16 Dec 2023 06:33:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=v4dSfFYfVHM2XTD/bnD+o5Xb7pjC73VIHI6OFu1yqWo=; b=lBPmND9S5jjIKcLPgvHb m5QLzrG9AMuRpMq4IwX3zQqh754gLllG8+tDCeluH8REEumnTpk1x9OldMCpst7d8mrmPB3szOdZD 8sMi19Gow1pvfflS2Lsp6WaRRlmR/zVuFPOi09+5Vqxk7rDa+eDtktA5qNEBx3i5OkorLtzN1K74Z z5WiRw5rJhrBY8haEdDreGSMFURMKaZX0l8e3tv3sbFdess79rwIdgMfk7l8QEMIJluHhri0MPG1F h8Ck+6AeHf7Tb/DqGb08EL3j8mBfGFA9ZENazPwD4baYvvP3kP33jsNkp5mtU0Z5KsgP+PxNTcHup e+jGxmwCOBEtGg==; In-Reply-To: (one.last.kiss@outlook.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276315 Archived-At: > From: ". shynur" > Date: Wed, 6 Dec 2023 11:17:41 +0000 > > Reproduce: > > PS D:/Tmp> dir > test.txt test.org > PS D:/Tmp> runemacs.exe -Q > > (require 'filesets) > (push `("Teest" > . ((:tree ,default-directory ""))) filesets-data) > (filesets-init) > > M-x eval-buffer > > Click: Menu-Bar -> File -> Filesets -> 0 Teest -> Tree: d:/Tmp/ > > Then emacs just gave me an error: > ˇ°filesets-files-under: Wrong type argument: stringp, nilˇ± > > I expected it to open all the files under that directory. > Am I missing something? You are not missing anything, this has been broken since Emacs 28.1, where we installed a change which fixed "normal" invocation of filesets-open, but broke its invocations from the menu-bar menus. The breakage was due to omitting from the fix to bug#976 the cautious 'if' clause in the original author's code. This should be fixed now on the emacs-29 branch.