From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii <eliz@gnu.org> Newsgroups: gmane.emacs.bugs Subject: bug#66394: 29.1; Make register-read-with-preview more useful Date: Thu, 21 Dec 2023 13:47:51 +0200 Message-ID: <83wmt7g4k8.fsf@gnu.org> References: <87il7ib6cu.fsf@posteo.net> <83jzpkvs4z.fsf@gnu.org> <87v8947ulo.fsf@posteo.net> <871qbsk5le.fsf@posteo.net> <f7f749d1-3a2d-0ea0-a106-6c586f4faca7@gutov.dev> <87v894hr2e.fsf@posteo.net> <87cyvbepi0.fsf@posteo.net> <87bkavk9nv.fsf@posteo.net> <8eebbb30-9366-e869-a39a-8100638cb99a@gutov.dev> <87o7etgxeb.fsf@posteo.net> <83v891qlcn.fsf@gnu.org> <jwvfs04hjm9.fsf-monnier+emacs@gnu.org> <CADwFkmm3H9+-nrYi0JQM9YT0_ZYU3SYvcqfmEnEpJWWaZzHTGQ@mail.gmail.com> <87r0jn4j8i.fsf@posteo.net> <jwv8r5vfqo6.fsf-monnier+emacs@gnu.org> <87jzpf48k5.fsf@posteo.net> <jwvplz73vpg.fsf-monnier+emacs@gnu.org> <87plz6xp3m.fsf@posteo.net> <jwvzfya2mk9.fsf-monnier+emacs@gnu.org> <8734vym6ok.fsf@posteo.net> <83ttodgjtk.fsf@gnu.org> <87cyv0hjp9.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40820"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, dmitry@gutov.dev, 66394@debbugs.gnu.org, monnier@iro.umontreal.ca, stefankangas@gmail.com To: Thierry Volpiatto <thievol@posteo.net> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 21 12:49:26 2023 Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org> Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>) id 1rGHYK-000AQM-Lx for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Dec 2023 12:49:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <bug-gnu-emacs-bounces@gnu.org>) id 1rGHXy-0005tG-MQ; Thu, 21 Dec 2023 06:49:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rGHXv-0005sO-J4 for bug-gnu-emacs@gnu.org; Thu, 21 Dec 2023 06:48:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rGHXv-0005EW-Am for bug-gnu-emacs@gnu.org; Thu, 21 Dec 2023 06:48:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rGHXy-0007kI-Tw for bug-gnu-emacs@gnu.org; Thu, 21 Dec 2023 06:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii <eliz@gnu.org> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Dec 2023 11:49:02 +0000 Resent-Message-ID: <handler.66394.B66394.170315932529689@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66394 X-GNU-PR-Package: emacs Original-Received: via spool by 66394-submit@debbugs.gnu.org id=B66394.170315932529689 (code B ref 66394); Thu, 21 Dec 2023 11:49:02 +0000 Original-Received: (at 66394) by debbugs.gnu.org; 21 Dec 2023 11:48:45 +0000 Original-Received: from localhost ([127.0.0.1]:42557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1rGHXh-0007ij-3r for submit@debbugs.gnu.org; Thu, 21 Dec 2023 06:48:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@gnu.org>) id 1rGHXe-0007ht-15 for 66394@debbugs.gnu.org; Thu, 21 Dec 2023 06:48:44 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1rGHXT-0005A4-Lj; Thu, 21 Dec 2023 06:48:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4utp0pYMMYS5XmsOrTAFYA8+TMXvQunCCCZtrAOgxDI=; b=q/3csal/XNOd v+NJmBReXrNBLG4EhxaFMyXho4oLeftK0/ec5wuzsA0qVm6w21bu6oAGUaIwcp9MTKUoD+rybf5IC gyCwJoX5g+To5xPXUAqJvLOhy+80IhDZqARCG4SgxKQO/69hvrmF/PD9bIgT35xM4xlLWcl0hP+LB o0KqMmUJd4J/FSJdot+kQ6q3fosVzAatm7WsXxmYFc6XGXYEirG/AzaToliAtEtrzgcFdfyXmEAEt 5rlcYP0D0lbfRewgkt4sw3MCUa+cc4W3JHEsF5QAygrgR146DPlHDJtokQv0d1gH/hIYwoP/3HTDF NOded0NCYiqogGpwvmg6bw==; In-Reply-To: <87cyv0hjp9.fsf@posteo.net> (message from Thierry Volpiatto on Wed, 20 Dec 2023 17:23:14 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs> List-Post: <mailto:bug-gnu-emacs@gnu.org> List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe> Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276622 Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/276622> > From: Thierry Volpiatto <thievol@posteo.net> > Cc: monnier@iro.umontreal.ca, stefankangas@gmail.com, dmitry@gutov.dev, > michael_heerdegen@web.de, 66394@debbugs.gnu.org > Date: Wed, 20 Dec 2023 17:23:14 +0000 > > > . I suggest to rename all the "*basic" symbols to "*traditional" > > instead (including such words in some doc strings) > > Ok, done. Have a look though to verify if docstring is correct. > > > . I think we need to update the NEWS entry, and in particular > > describe there the two different "styles" of entering the register > > names and the preview modes > > I would prefer you do this, it will be better written. > > > (I'm okay with doing these minor changes myself, once you install the > > changes.) > > Ok, now merged, Thanks. Thanks, I have a question: The doc string of register-use-preview says: This has no effect when the value of `register--read-with-preview-function' is `register-read-with-preview-traditional'. However, customizing register-use-preview to the value 'traditional has the exact effect of setting register--read-with-preview-function to register-read-with-preview-traditional. OTOH, when register-use-preview is set to 'traditional, one can set it to a different value, and then the behavior will change. So I wonder what that sentence is about and what I missed? Is that perhaps a leftover from previous versions, and should now be deleted? I updated the documentation and NEWS. I'd appreciate if you could spare a few minutes to review the changes and point out any inaccuracies or mistakes.