From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Elisp native profiler Date: Thu, 27 Sep 2012 09:01:45 +0200 Message-ID: <83vcf0eyp2.fsf@gnu.org> References: <83zk4egs0w.fsf@gnu.org> <83y5jygrni.fsf@gnu.org> <50620443.8050301@cs.ucla.edu> <20120926151625.229ef3cc9caf90e5098b18ef@cx4a.org> <83ipb1grs9.fsf@gnu.org> <20120926165946.87a9f8c58aad890dafb50494@cx4a.org> <83d319gmd6.fsf@gnu.org> <20120927074655.a943e298fc9319a438825f47@cx4a.org> <83wqzgf1qs.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1348729318 25371 80.91.229.3 (27 Sep 2012 07:01:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 27 Sep 2012 07:01:58 +0000 (UTC) Cc: eggert@cs.ucla.edu, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: tomo@cx4a.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 27 09:02:03 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TH86j-0005xJ-SC for ged-emacs-devel@m.gmane.org; Thu, 27 Sep 2012 09:02:01 +0200 Original-Received: from localhost ([::1]:41756 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TH86e-0008Kj-Ru for ged-emacs-devel@m.gmane.org; Thu, 27 Sep 2012 03:01:56 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TH86b-0008KV-M0 for emacs-devel@gnu.org; Thu, 27 Sep 2012 03:01:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TH86W-0001EM-0d for emacs-devel@gnu.org; Thu, 27 Sep 2012 03:01:53 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:48754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TH86V-0001E1-HK for emacs-devel@gnu.org; Thu, 27 Sep 2012 03:01:47 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MAZ00400Y63HH00@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Thu, 27 Sep 2012 09:01:46 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MAZ0043NY6X1880@a-mtaout22.012.net.il>; Thu, 27 Sep 2012 09:01:45 +0200 (IST) In-reply-to: <83wqzgf1qs.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153623 Archived-At: I think profiler-cpu-stop should revert the SIGPROF handler to its original value. Currently, it only disables the interval timer, but leaves the SIGPROF handler pointed at its handler in profiler.c, which ain't right AFAICS. Btw, the names profiler-cpu-* are not good names, IMO: the "cpu" part is not correct. How about profiler-funcall-* or profiler-execution-* instead?