From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#13070: Use putenv+unsetenv instead of modifying environ directly Date: Sat, 08 Dec 2012 20:31:18 +0200 Message-ID: <83vccccs5l.fsf@gnu.org> References: <50BD0C72.7070601@cs.ucla.edu> <50C2BBD9.8060401@cs.ucla.edu> <83zk1olqh8.fsf@gnu.org> <50C376F9.3000603@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1354991563 24156 80.91.229.3 (8 Dec 2012 18:32:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 8 Dec 2012 18:32:43 +0000 (UTC) Cc: 13070@debbugs.gnu.org, fabrice.popineau@gmail.com To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 08 19:32:56 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ThPCq-00060P-2u for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Dec 2012 19:32:56 +0100 Original-Received: from localhost ([::1]:46549 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThPCd-00009W-Mu for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Dec 2012 13:32:43 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39167) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThPCa-00009Q-Az for bug-gnu-emacs@gnu.org; Sat, 08 Dec 2012 13:32:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ThPCX-00014D-2y for bug-gnu-emacs@gnu.org; Sat, 08 Dec 2012 13:32:40 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51137) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ThPCX-000142-04 for bug-gnu-emacs@gnu.org; Sat, 08 Dec 2012 13:32:37 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1ThPCv-0007N2-S6 for bug-gnu-emacs@gnu.org; Sat, 08 Dec 2012 13:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Dec 2012 18:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13070 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13070-submit@debbugs.gnu.org id=B13070.135499152528264 (code B ref 13070); Sat, 08 Dec 2012 18:33:01 +0000 Original-Received: (at 13070) by debbugs.gnu.org; 8 Dec 2012 18:32:05 +0000 Original-Received: from localhost ([127.0.0.1]:33155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThPC0-0007Lo-Oc for submit@debbugs.gnu.org; Sat, 08 Dec 2012 13:32:04 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:34441) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ThPBy-0007LP-DB for 13070@debbugs.gnu.org; Sat, 08 Dec 2012 13:32:04 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MEQ00B005WQ3300@a-mtaout23.012.net.il> for 13070@debbugs.gnu.org; Sat, 08 Dec 2012 20:31:35 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MEQ00AFM64LZV10@a-mtaout23.012.net.il>; Sat, 08 Dec 2012 20:31:35 +0200 (IST) In-reply-to: <50C376F9.3000603@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:68195 Archived-At: > Date: Sat, 08 Dec 2012 09:20:57 -0800 > From: Paul Eggert > CC: fabrice.popineau@gmail.com, 13070-done@debbugs.gnu.org > > On 12/08/2012 03:42 AM, Eli Zaretskii wrote: > > Shouldn't we refrain from signaling memory_full when errno is EINVAL? > > I'd suggest an eassert in that case. memory_full will emit a > > misleading diagnostic. > > errno cannot be EINVAL, at least not on a POSIXish host: > all strings are allowed as arguments to putenv. What about NULL pointers? Or strings without a '='? IMO, it's silly to rely on unspecified behavior, but suit yourself. > I did see a minor problem in the w32.c implementation of unsetenv: > > /* MS docs says an environment variable cannot be longer than 32K. */ > if (name_len > 32767) > { > errno = ENOMEM; > return -1; > } > > unsetenv should return 0 in that case, not -1, since > the variable cannot possibly be in the environment. Right, I fixed that.