From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#13623: 24.3.50; Redisplay issue with transient-mark-mode Date: Mon, 04 Feb 2013 17:49:54 +0200 Message-ID: <83vca89izh.fsf@gnu.org> References: <877gmp5a04.fsf@ed.ac.uk> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1359993065 10204 80.91.229.3 (4 Feb 2013 15:51:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Feb 2013 15:51:05 +0000 (UTC) Cc: 13623@debbugs.gnu.org To: Lawrence Mitchell , Dmitry Antipov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 04 16:51:22 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U2OKH-0001Yz-Sv for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Feb 2013 16:51:22 +0100 Original-Received: from localhost ([::1]:34280 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2OJz-0002LA-CV for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Feb 2013 10:51:03 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:38837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2OJv-0002Kp-O1 for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2013 10:51:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U2OJu-0006sM-1n for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2013 10:50:59 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2OJt-0006sH-TW for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2013 10:50:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U2OKw-0000eo-Fu for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2013 10:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Feb 2013 15:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 13623-submit@debbugs.gnu.org id=B13623.13599930782470 (code B ref 13623); Mon, 04 Feb 2013 15:52:02 +0000 Original-Received: (at 13623) by debbugs.gnu.org; 4 Feb 2013 15:51:18 +0000 Original-Received: from localhost ([127.0.0.1]:36163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2OKE-0000dm-6j for submit@debbugs.gnu.org; Mon, 04 Feb 2013 10:51:18 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:62581) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2OKA-0000da-UW for 13623@debbugs.gnu.org; Mon, 04 Feb 2013 10:51:16 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MHP00600DAG6Y00@a-mtaout22.012.net.il> for 13623@debbugs.gnu.org; Mon, 04 Feb 2013 17:49:46 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MHP0063DDAY5Y20@a-mtaout22.012.net.il>; Mon, 04 Feb 2013 17:49:46 +0200 (IST) In-reply-to: <877gmp5a04.fsf@ed.ac.uk> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70678 Archived-At: > From: Lawrence Mitchell > Date: Sun, 03 Feb 2013 22:05:15 +0000 > > > When using word or sexp marking commands, the active region does not > always get highlighted. > > emacs -Q > M-< > M-@ # note how ";; This" is selected, and highlighted in region-face > M-@ # ";; This buffer" is selected, however, " buffer" is not highlighted > > Pressing C-l at this point, correctly shows the highlighted region. Thanks, should be fixed now (revision 111673 on the trunk). Dmitry, this bug and also 13626 were both caused by your changes in revision 111647. While the reason for the changes was to use non-Lisp objects for some fields, several hunks in the changeset had no relation whatsoever to that, and were highly questionable. Example: - /* If showing the region, and mark has changed, we must redisplay - the whole window. The assignment to this_line_start_pos prevents - the optimization directly below this if-statement. */ - if (((!NILP (Vtransient_mark_mode) - && !NILP (BVAR (XBUFFER (w->buffer), mark_active))) - != !NILP (w->region_showing)) - || (!NILP (w->region_showing) - && !EQ (w->region_showing, - Fmarker_position (BVAR (XBUFFER (w->buffer), mark))))) - CHARPOS (this_line_start_pos) = 0; I don't understand why such non-trivial code is being dropped on the floor without discussion. And there were others like this in this revision. Please don't assume that any dropped code that is really needed will cause bugs that will be immediately reported. I've seen display bugs that went unnoticed for months and even years. In this case, we were just lucky.