From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#14970: crash deleting frames Date: Mon, 29 Jul 2013 18:29:20 +0300 Message-ID: <83vc3txu3z.fsf@gnu.org> References: <51F4D8DA.9090806@gmx.at> <83zjt6ya92.fsf@gnu.org> <51F61FD2.9060600@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1375112753 17071 80.91.229.3 (29 Jul 2013 15:45:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Jul 2013 15:45:53 +0000 (UTC) Cc: lekktu@gmail.com, 14970@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 29 17:45:52 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V3pdq-0003GN-VL for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Jul 2013 17:45:47 +0200 Original-Received: from localhost ([::1]:56658 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3pdq-0006dR-HG for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Jul 2013 11:45:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3pdh-0006aD-Gn for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2013 11:45:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3pdb-0005oK-EB for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2013 11:45:37 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33751) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3pOh-0000r9-PL for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2013 11:30:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1V3pOf-0005l5-GO for bug-gnu-emacs@gnu.org; Mon, 29 Jul 2013 11:30:06 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jul 2013 15:30:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14970 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14970-submit@debbugs.gnu.org id=B14970.137511177621945 (code B ref 14970); Mon, 29 Jul 2013 15:30:04 +0000 Original-Received: (at 14970) by debbugs.gnu.org; 29 Jul 2013 15:29:36 +0000 Original-Received: from localhost ([127.0.0.1]:56300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3pOB-0005ho-Tl for submit@debbugs.gnu.org; Mon, 29 Jul 2013 11:29:36 -0400 Original-Received: from mtaout21.012.net.il ([80.179.55.169]:50559) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1V3pO9-0005gy-8I for 14970@debbugs.gnu.org; Mon, 29 Jul 2013 11:29:34 -0400 Original-Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MQP00300EX25T00@a-mtaout21.012.net.il> for 14970@debbugs.gnu.org; Mon, 29 Jul 2013 18:29:13 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MQP003E6F0O5420@a-mtaout21.012.net.il>; Mon, 29 Jul 2013 18:29:13 +0300 (IDT) In-reply-to: <51F61FD2.9060600@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:76765 Archived-At: > Date: Mon, 29 Jul 2013 09:54:58 +0200 > From: martin rudalics > CC: lekktu@gmail.com, 14970@debbugs.gnu.org > > > ... (you cannot just > > use FRAME_LIVE_P here, because it will crash in the same way). > > How does it crash? The original crash was a SIGSEGV because f was a null pointer, and FRAME_SELECTED_WINDOW dereferenced it. But FRAME_LIVE_P also dereferences its argument, so it would have crashed with the same SIGSEGV. I guess you are thinking about a frame pointer computed from a Lisp frame object, in which case the pointer can never be null. But this is not that case: here we get the frame pointer from a call to x_window_to_frame, which returns a null pointer to signal that it failed to find an Emacs frame that corresponds to a Windows window.