From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#16448: 24.3; Messages from (error "...") with UTF-8 chars are printed wrongly in Emacs Lisp scripts Date: Wed, 15 Jan 2014 17:35:43 +0200 Message-ID: <83vbxl45rk.fsf@gnu.org> References: <20140115111009.dc0d435fa9991c3e15816f84@gmail.com> <52D60869.1000206@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1389800177 1208 80.91.229.3 (15 Jan 2014 15:36:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Jan 2014 15:36:17 +0000 (UTC) Cc: 16448@debbugs.gnu.org, stselikh@gmail.com To: Dmitry Antipov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 15 16:36:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W3SVv-0004pu-8s for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Jan 2014 16:36:19 +0100 Original-Received: from localhost ([::1]:55551 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3SVu-0006mW-TX for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Jan 2014 10:36:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3SVm-0006g6-3J for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2014 10:36:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W3SVe-0001pW-0v for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2014 10:36:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38174) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W3SVd-0001pQ-Rv for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2014 10:36:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1W3SVd-0004Yl-J8 for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2014 10:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jan 2014 15:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16448 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 16448-submit@debbugs.gnu.org id=B16448.138980015417511 (code B ref 16448); Wed, 15 Jan 2014 15:36:01 +0000 Original-Received: (at 16448) by debbugs.gnu.org; 15 Jan 2014 15:35:54 +0000 Original-Received: from localhost ([127.0.0.1]:52193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3SVV-0004YM-SW for submit@debbugs.gnu.org; Wed, 15 Jan 2014 10:35:54 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:34127) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3SVS-0004Y9-5j for 16448@debbugs.gnu.org; Wed, 15 Jan 2014 10:35:51 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MZG009008N4BS00@a-mtaout20.012.net.il> for 16448@debbugs.gnu.org; Wed, 15 Jan 2014 17:35:48 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MZG009JF8NN0Y70@a-mtaout20.012.net.il>; Wed, 15 Jan 2014 17:35:48 +0200 (IST) In-reply-to: <52D60869.1000206@yandex.ru> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:83536 Archived-At: > Date: Wed, 15 Jan 2014 08:02:49 +0400 > From: Dmitry Antipov > Cc: 16448@debbugs.gnu.org > > On 01/15/2014 04:10 AM, Sergey Tselikh wrote: > > > In a script, when (error "...") instruction is executed with some UTF-8 > > characters in its text, the message is not printed correctly. > > In batch mode, (error ...) is handled by external-debugging-output, and the > latter just does: > > putc (XINT (character) & 0xFF, stderr); > ^^^^^^ > To allow multibyte sequences here, we should use something like: > > === modified file 'src/print.c' > --- src/print.c 2014-01-01 07:43:34 +0000 > +++ src/print.c 2014-01-15 03:55:39 +0000 > @@ -709,8 +709,14 @@ > to make it write to the debugging output. */) > (Lisp_Object character) > { > + unsigned char str[MAX_MULTIBYTE_LENGTH]; > + unsigned int ch; > + ptrdiff_t len; > + > CHECK_NUMBER (character); > - putc (XINT (character) & 0xFF, stderr); > + ch = XINT (character); > + len = CHAR_STRING (ch, str); > + fwrite (str, len, 1, stderr); This will only work correctly in a UTF-8 locale. In the general case, we need to run the resulting multibyte sequence through ENCODE_SYSTEM, before writing it to stderr. Btw, the way we output text in this case cries for refactoring: we first assemble individual characters from their multibyte sequences, then pass those characters one by one to external-debugging-output, which will now have to unroll each character back into its multibyte sequence, and encode each character individually. Something for after the branch, I guess.