all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Aleksey Cherepanov <aleksey.4erepanov@gmail.com>
Cc: 16800@debbugs.gnu.org, agustin.martin@hispalinux.es
Subject: bug#16800: 24.3; flyspell works slow on very short words at the end of big file
Date: Sat, 22 Feb 2014 15:10:02 +0200	[thread overview]
Message-ID: <83vbw72t05.fsf@gnu.org> (raw)
In-Reply-To: <20140222124413.GA4971@openwall.com>

> Date: Sat, 22 Feb 2014 16:44:13 +0400
> From: Aleksey Cherepanov <aleksey.4erepanov@gmail.com>
> Cc: Agustin Martin <agustin.martin@hispalinux.es>, 16800@debbugs.gnu.org
> 
> Also GNU coding standards say to avoid arbitrary limits (parts 2.1
> and 4.2).
> http://www.gnu.org/prep/standards/standards.html

This limit is not arbitrary.

> > > > I tried to patch flyspell-word-search-backward and
> > > > flyspell-word-search-forward functions from flyspell.el replacing
> > > > search-backward with word-search-backward and search-forward with
> > > > word-search-forward (perl -pe 's/\(search-/(word-search-/' ). It
> > > > solved the problem but I do not know what it broke.
> > 
> > And this doesn't change behavior?  See below.
> 
> No, it seems that my setup works the same. See below.

Your setup _might_ work the same, especially if you don't mix
different languages in the same buffer.  But in general, your change
does affect behavior.

> The difference is in word bounds. We are in trouble if flyspell's word
> on its ends does not have ends of emacs' word. If flyspell's word has
> ends of emacs' word on its ends and even contain them inside then we
> are ok (try to search "a b" over "aa bb a b aa bb"). So could ends of
> flyspell's word do not match with ends of emacs' word?

Yes, definitely.  See what flyspell-get-word does to find where the
word begins and where it ends.  Flyspell's "words" are
language-sensitive, whereas Emacs's words are not.





  reply	other threads:[~2014-02-22 13:10 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-18 20:56 bug#16800: 24.3; flyspell works slow on very short words at the end of big file Aleksey Cherepanov
2014-02-21 10:15 ` Eli Zaretskii
2014-02-21 14:38   ` Agustin Martin
2014-02-21 15:12     ` Eli Zaretskii
2014-02-21 15:21       ` Eli Zaretskii
2014-02-22 12:44       ` Aleksey Cherepanov
2014-02-22 13:10         ` Eli Zaretskii [this message]
2014-02-22 16:02           ` Aleksey Cherepanov
2014-02-22 16:41             ` Eli Zaretskii
2014-02-22 18:55               ` Aleksey Cherepanov
2014-02-22 20:16                 ` Aleksey Cherepanov
2014-02-22 21:03                 ` Eli Zaretskii
2014-02-23  1:26                   ` Agustin Martin
2014-02-23 18:36                     ` Eli Zaretskii
2014-02-23 19:56                     ` Aleksey Cherepanov
2014-02-23 23:02                       ` Aleksey Cherepanov
2014-02-24 16:03                         ` Aleksey Cherepanov
2014-02-26 20:32                           ` Agustin Martin
2014-02-28 11:45                             ` Agustin Martin
2014-02-28 11:51                               ` Eli Zaretskii
2014-03-01 21:44                                 ` Aleksey Cherepanov
2014-03-02  3:56                                   ` Eli Zaretskii
2014-03-09 17:36                                     ` Agustin Martin
2014-03-09 18:02                                       ` Aleksey Cherepanov
2014-03-09 18:24                                         ` Eli Zaretskii
2014-02-28 23:11                               ` Aleksey Cherepanov
2014-03-01 10:33                                 ` Aleksey Cherepanov
2014-03-01 15:50                                   ` Aleksey Cherepanov
2014-03-01 21:39                                 ` Aleksey Cherepanov
2014-03-09 17:25                                 ` Agustin Martin
2015-03-06 21:46                                   ` Agustin Martin
2015-03-07  8:09                                     ` Eli Zaretskii
2014-02-23 20:39                     ` Aleksey Cherepanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83vbw72t05.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=16800@debbugs.gnu.org \
    --cc=agustin.martin@hispalinux.es \
    --cc=aleksey.4erepanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.