From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19101: 25.0.50; vc-print-log puts wrong buffer into log-view-mode Date: Wed, 19 Nov 2014 20:52:47 +0200 Message-ID: <83vbmb6n0g.fsf@gnu.org> References: <8761eb8yw4.fsf@violet.siamics.net> <83d28j88ws.fsf@gnu.org> <87ppcj3zi6.fsf@violet.siamics.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Trace: ger.gmane.org 1416423211 27102 80.91.229.3 (19 Nov 2014 18:53:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Nov 2014 18:53:31 +0000 (UTC) Cc: 19101@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 19 19:53:24 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XrANX-0000fc-G6 for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Nov 2014 19:53:23 +0100 Original-Received: from localhost ([::1]:60200 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrANX-00068k-5y for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Nov 2014 13:53:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrANN-000685-Pd for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 13:53:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XrAND-0006RW-5z for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 13:53:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41381) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XrAND-0006RN-25 for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 13:53:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XrANC-0007Dy-9x for bug-gnu-emacs@gnu.org; Wed, 19 Nov 2014 13:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Nov 2014 18:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19101-submit@debbugs.gnu.org id=B19101.141642317627757 (code B ref 19101); Wed, 19 Nov 2014 18:53:02 +0000 Original-Received: (at 19101) by debbugs.gnu.org; 19 Nov 2014 18:52:56 +0000 Original-Received: from localhost ([127.0.0.1]:38594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrAN5-0007Dd-RM for submit@debbugs.gnu.org; Wed, 19 Nov 2014 13:52:56 -0500 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:64596) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XrAN2-0007DT-Uy for 19101@debbugs.gnu.org; Wed, 19 Nov 2014 13:52:54 -0500 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NFA00A00UUTWZ00@a-mtaout23.012.net.il> for 19101@debbugs.gnu.org; Wed, 19 Nov 2014 20:52:51 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NFA00A1OV42XG00@a-mtaout23.012.net.il>; Wed, 19 Nov 2014 20:52:51 +0200 (IST) In-reply-to: <87ppcj3zi6.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:96261 > From: Ivan Shmakov > Date: Wed, 19 Nov 2014 16:51:13 +0000 > > >> This is likely to be caused by VC assuming that the ‘print-log’ > >> backend function leaves the log buffer as the current one. > > > No, it's because Stefan moved the call to pop-to-buffer so that the > > part that turned on the mode was running in the wrong buffer. > > ACK, but that change seem to be dated 2014-11-05, while I’ve > observed a similar issue (with non-Emacs code, though) before. > Or so I think. The problem reported in this bug started happening on 2014-11-05. > > As for print-log backend function, those that I saw run inside > > with-temp-buffer, so they don't switch buffers. > > There’re several which use vc-setup-buffer, which in turn calls > set-buffer. But no one relies on that.