From: Eli Zaretskii <eliz@gnu.org>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: 19721@debbugs.gnu.org
Subject: bug#19721: 25.0.50; Mode-line not redrawn with expose events
Date: Sun, 01 Feb 2015 17:33:10 +0200 [thread overview]
Message-ID: <83vbjlir49.fsf@gnu.org> (raw)
In-Reply-To: <wl61bm6vfr.wl%mituharu@math.s.chiba-u.ac.jp>
> Date: Sun, 01 Feb 2015 14:40:40 +0900
> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
> Cc: 19721@debbugs.gnu.org
>
> > How about the following patch instead of the previous one?
>
> Now mode-lines get updated with C-x o again, but the original issue
> still remains and I could reproduce it with the original procedure on
> Cent OS 5.11.
>
> If I apply both changes, mode-lines are redrawn when exposed, but some
> of them are not updated with C-x o.
How about the patch below? (Once again, it's wrt the current emacs-24
branch.)
diff --git a/src/dispnew.c b/src/dispnew.c
index f73ea58..6517c9b 100644
--- a/src/dispnew.c
+++ b/src/dispnew.c
@@ -570,6 +570,12 @@ struct redisplay_history
for (i = 0; i < matrix->nrows; ++i)
matrix->rows[i].enabled_p = false;
}
+ /* We've disabled the mode-line row, so force redrawing of
+ the mode line, if any, since otherwise it will remain
+ disabled in the current matrix, and expose events won't
+ redraw it. */
+ if (WINDOW_WANTS_MODELINE_P (w))
+ w->update_mode_line = 1;
}
else if (matrix == w->desired_matrix)
{
diff --git a/src/xdisp.c b/src/xdisp.c
index b1125d3..2ebf06d 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -15964,6 +15964,7 @@ enum
if (!just_this_one_p
&& REDISPLAY_SOME_P ()
&& !w->redisplay
+ && !w->update_mode_line
&& !f->redisplay
&& !buffer->text->redisplay
&& BUF_PT (buffer) == w->last_point)
next prev parent reply other threads:[~2015-02-01 15:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 10:51 bug#19721: 25.0.50; Mode-line not redrawn with expose events YAMAMOTO Mitsuharu
2015-01-31 10:31 ` YAMAMOTO Mitsuharu
2015-01-31 11:09 ` Eli Zaretskii
2015-01-31 10:53 ` Eli Zaretskii
2015-01-31 11:37 ` YAMAMOTO Mitsuharu
2015-01-31 11:44 ` Eli Zaretskii
2015-02-01 5:40 ` YAMAMOTO Mitsuharu
2015-02-01 8:51 ` martin rudalics
2015-02-01 15:44 ` Eli Zaretskii
2015-02-01 16:30 ` martin rudalics
2015-02-01 17:27 ` Eli Zaretskii
2015-02-01 18:09 ` martin rudalics
2015-02-01 18:37 ` Eli Zaretskii
2015-02-02 3:24 ` YAMAMOTO Mitsuharu
2015-02-01 15:33 ` Eli Zaretskii [this message]
2015-02-02 3:27 ` YAMAMOTO Mitsuharu
2015-02-02 16:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vbjlir49.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=19721@debbugs.gnu.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.