From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode Date: Wed, 25 Feb 2015 18:06:50 +0200 Message-ID: <83vbiq561x.fsf@gnu.org> References: <87pp953q1j.fsf_-_@violet.siamics.net> <83lhjslwup.fsf@gnu.org> <87h9ug4dk1.fsf@violet.siamics.net> <87d25447e8.fsf@violet.siamics.net> <874mqf4ixf.fsf@violet.siamics.net> <83lhjrcwy6.fsf@gnu.org> <87sidu3423.fsf@violet.siamics.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Trace: ger.gmane.org 1424880506 23851 80.91.229.3 (25 Feb 2015 16:08:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Feb 2015 16:08:26 +0000 (UTC) Cc: 19903@debbugs.gnu.org To: Ivan Shmakov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 25 17:08:15 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YQeVT-0003zW-IB for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Feb 2015 17:08:15 +0100 Original-Received: from localhost ([::1]:54802 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQeVS-0003Sr-Qm for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Feb 2015 11:08:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQeUO-0001jL-J7 for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 11:07:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQeUI-0008Sz-Lv for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 11:07:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54319) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQeUI-0008Sv-JA for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 11:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YQeUI-000552-3G for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2015 11:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Feb 2015 16:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19903 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19903-submit@debbugs.gnu.org id=B19903.142488040919504 (code B ref 19903); Wed, 25 Feb 2015 16:07:02 +0000 Original-Received: (at 19903) by debbugs.gnu.org; 25 Feb 2015 16:06:49 +0000 Original-Received: from localhost ([127.0.0.1]:57917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQeU4-00054W-JA for submit@debbugs.gnu.org; Wed, 25 Feb 2015 11:06:48 -0500 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:47265) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YQeU1-00054E-Jh for 19903@debbugs.gnu.org; Wed, 25 Feb 2015 11:06:47 -0500 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NKC00D004FJGV00@a-mtaout20.012.net.il> for 19903@debbugs.gnu.org; Wed, 25 Feb 2015 18:06:38 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKC00D7B4R1FF50@a-mtaout20.012.net.il>; Wed, 25 Feb 2015 18:06:38 +0200 (IST) In-reply-to: <87sidu3423.fsf@violet.siamics.net> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99801 Archived-At: > From: Ivan Shmakov > Date: Wed, 25 Feb 2015 06:20:36 +0000 > > > I don't think internal functions should cater to UI issues, unless > > they are themselves interactive. > > I’m unsure where you see an UI issue here? The issue, as > originally reported, is that face-attribute fails to handle > string-named faces, which are considered perfectly valid by the > rest of Emacs (including, say, facep and the display engine.) Accepting strings instead of symbols is a convenience feature for users, so it's a UI issue. > From there, we can go different ways, including: > > • bury our head in the sand and pretend there’s no issue; I don't think anybody suggested that; I certainly didn't. If you are now suggesting it, then no, I don't think we should. > • patch one or two of the functions which can be used to add > such faces – to either silently (or not so) replace them with > the respective symbol-named ones, /or/ to signal an error; > this won’t prevent, however, the use of put-text-property and > the likes of it to achieve that same effect; I don't see why we need to spread this so wide. Making facemenu.el behave consistently sounds good enough, and will solve the original report. > > If we keep this confined to interactive functions, how many such > > functions in facemenu.el will have to be changed? If not too many, > > I'm inclined to keep this there. > > I believe that facemenu-add-face is the only function which can > be used to add a string-named face /interactively/, as it reads > an arbitrary Lisp form for the face. (See also #18369.) Yes, but how many don't? > > The original report, however, was concerned with the use of > facemenu-add-face from Lisp, and there’re still a plenty of ways > to hit this issue apart from using facemenu-add-face with a > string argument. I don't think we need to consider them.