From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#19909: [PATCH] Error out if with-file-notification=w32 is specified on cygwin Date: Sat, 28 Feb 2015 21:14:06 +0200 Message-ID: <83vbilsvb5.fsf@gnu.org> References: <821tlkhq2v.fsf@gmail.com> <83mw48lwvx.fsf@gnu.org> <82wq3cga1n.fsf@gmail.com> <83ioewlv1v.fsf@gnu.org> <82sie0fz1q.fsf@gmail.com> <838ufslitm.fsf@gnu.org> <54E75D96.70601@cornell.edu> <83twygcxif.fsf@gnu.org> <54F0EEF2.1030908@cornell.edu> <83sidq4gb2.fsf@gnu.org> <54F1ED9D.9040303@cornell.edu> <83zj7yrntl.fsf@gnu.org> <83wq31syvm.fsf@gnu.org> <54F20C96.4020507@cornell.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1425150926 10893 80.91.229.3 (28 Feb 2015 19:15:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 28 Feb 2015 19:15:26 +0000 (UTC) Cc: 19909@debbugs.gnu.org, rpluim@gmail.com To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 28 20:15:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YRmr1-0003If-Oe for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Feb 2015 20:15:12 +0100 Original-Received: from localhost ([::1]:42182 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRmr0-0002il-UU for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Feb 2015 14:15:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRmqx-0002g2-0x for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 14:15:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRmqt-000266-Qt for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 14:15:06 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRmqt-00025q-NF for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 14:15:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YRmqt-00060s-7d for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 14:15:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Feb 2015 19:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: rpluim@gmail.com, bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.142515087123060 (code B ref -1); Sat, 28 Feb 2015 19:15:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Feb 2015 19:14:31 +0000 Original-Received: from localhost ([127.0.0.1]:60845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRmqN-0005zs-5k for submit@debbugs.gnu.org; Sat, 28 Feb 2015 14:14:31 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:34908) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YRmqK-0005ze-Gm for submit@debbugs.gnu.org; Sat, 28 Feb 2015 14:14:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRmqD-0001zW-QY for submit@debbugs.gnu.org; Sat, 28 Feb 2015 14:14:23 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:43924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRmqD-0001zP-NV for submit@debbugs.gnu.org; Sat, 28 Feb 2015 14:14:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRmqC-00027K-Ml for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 14:14:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRmq9-0001yz-EE for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 14:14:20 -0500 Original-Received: from mtaout25.012.net.il ([80.179.55.181]:35073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRmq9-0001yt-6N for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 14:14:17 -0500 Original-Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NKH00600WTWWR00@mtaout25.012.net.il> for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2015 21:08:55 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NKH004TSX6V0M40@mtaout25.012.net.il>; Sat, 28 Feb 2015 21:08:55 +0200 (IST) In-reply-to: <54F20C96.4020507@cornell.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99911 Archived-At: > Date: Sat, 28 Feb 2015 13:44:38 -0500 > From: Ken Brown > CC: bug-gnu-emacs@gnu.org > > > No, I meant your reasons for specifying --with-file-notification=w32. > > You could only bump into this issue if you specified it, AFAIU. > > Based on http://debbugs.gnu.org/cgi/bugreport.cgi?bug=19909#36, I think > he specified --with-file-notification=w32 because he wanted file > notification and didn't know he could use gfile. Isn't gfile the default for Cygwin? > I'm inclined to go ahead with the revised patch he submitted in the > above URL. I'll commit it (with Robert as author and with the change > marked as a "tiny change") if that's OK with you, Eli. If that's what Cygwin users want, fine with me. > 1. Shouldn't the name in the ChangeLog be "Robert Pluim" instead of > "rpluim" to match all the other entries? I don't think it matters when there's no assignment on file. > 2. I tested making a git commit with > > --author="Robert Pluim (tiny change)" > > but git stripped away the "(tiny change)" part. What should I do to get > "tiny change" into the git history? Maybe it's not so important now, > because I can put it into the ChangeLog, but I'm thinking about the > future, when ChangeLogs are automatically generated. The projects I know of use Copyright-paperwork-exempt: yes on a separate line in the log message. You will see that I already used that in Emacs, at least once.