From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: xref-find-matches and stuff Date: Wed, 13 May 2015 19:23:46 +0300 Message-ID: <83vbfwjvjh.fsf@gnu.org> References: <5546DD4A.2080709@yandex.ru> <87r3qvnld1.fsf@gmail.com> <5548E08A.4090305@yandex.ru> <87mw1jndul.fsf@gmail.com> <554964CE.3040809@yandex.ru> <87oalxn756.fsf@gmail.com> <554AAD41.6060506@yandex.ru> <87vbg4lgn6.fsf@gmail.com> <554CB069.8090002@yandex.ru> <554F4F91.6020604@gmx.at> <837fsgo5hz.fsf@gnu.org> <55507FAD.7020704@gmx.at> <83egmnm9wx.fsf@gnu.org> <5551C983.5000705@gmx.at> <83mw19lqli.fsf@gnu.org> <55522E6B.6000003@yandex.ru> <83fv71lmsv.fsf@gnu.org> <837fsdlgbk.fsf@gnu.org> <55525F57.8040904@yandex.ru> <834mnhkxr0.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1431534269 20257 80.91.229.3 (13 May 2015 16:24:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 May 2015 16:24:29 +0000 (UTC) Cc: rudalics@gmx.at, emacs-devel@gnu.org To: dgutov@yandex.ru Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 13 18:24:21 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YsZSF-0000Ht-0y for ged-emacs-devel@m.gmane.org; Wed, 13 May 2015 18:24:19 +0200 Original-Received: from localhost ([::1]:50077 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsZSE-0005c0-2j for ged-emacs-devel@m.gmane.org; Wed, 13 May 2015 12:24:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58581) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsZS5-0005bg-Hv for emacs-devel@gnu.org; Wed, 13 May 2015 12:24:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YsZS2-00080l-Bs for emacs-devel@gnu.org; Wed, 13 May 2015 12:24:09 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:57223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YsZS2-00080Q-4U for emacs-devel@gnu.org; Wed, 13 May 2015 12:24:06 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NOA00C00QTRI800@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Wed, 13 May 2015 19:23:52 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NOA00CH1QVR5480@a-mtaout22.012.net.il>; Wed, 13 May 2015 19:23:52 +0300 (IDT) In-reply-to: <834mnhkxr0.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:186480 Archived-At: > Date: Wed, 13 May 2015 05:38:27 +0300 > From: Eli Zaretskii > Cc: rudalics@gmx.at, emacs-devel@gnu.org > > > Thank you. But I was going to say that it doesn't match because NONAM > > (see the comment above make_tag) does not include the double-quote > > character (and tag-implicit-name-match-p obeys that). > > Yes, that was the reason. I just helped etags use the explicit-name > alternative in this case. Btw, note the dramatic effect of this change on the results returned by M-. for DEFVAR_LISP. IOW, formerly src/TAGS would tell Emacs that all of this was the tag: DEFVAR_LISP ("pointer-make-invisible" Which, of course, is incorrect, and caused a lot of false positives. So the change to specify exactly where in the matched line is the tag name was indeed in order, and the fact that \(..\) was used in the regexp was a hint that it was intended. If nothing else, the Emacs manual explicitly advises to do so (which was how I became aware of the feature in the first place).