From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Missing frame parameters on tty's Date: Thu, 03 Dec 2015 09:34:42 +0200 Message-ID: <83vb8ghtnx.fsf@gnu.org> References: <20151202221534.GC2318@acm.fritz.box> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1449128186 27882 80.91.229.3 (3 Dec 2015 07:36:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Dec 2015 07:36:26 +0000 (UTC) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 03 08:36:18 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a4OR5-0004nW-L3 for ged-emacs-devel@m.gmane.org; Thu, 03 Dec 2015 08:36:15 +0100 Original-Received: from localhost ([::1]:33787 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4OR5-0003ZM-0Q for ged-emacs-devel@m.gmane.org; Thu, 03 Dec 2015 02:36:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4OQk-0003XE-E3 for emacs-devel@gnu.org; Thu, 03 Dec 2015 02:35:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4OQg-0003iB-BL for emacs-devel@gnu.org; Thu, 03 Dec 2015 02:35:54 -0500 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:50338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4OQg-0003i2-3d for emacs-devel@gnu.org; Thu, 03 Dec 2015 02:35:50 -0500 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NYR00600UC0DX00@mtaout28.012.net.il> for emacs-devel@gnu.org; Thu, 03 Dec 2015 09:34:01 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NYR0004GUCPYR50@mtaout28.012.net.il>; Thu, 03 Dec 2015 09:34:01 +0200 (IST) In-reply-to: <20151202221534.GC2318@acm.fritz.box> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.184 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195798 Archived-At: > Date: Wed, 2 Dec 2015 22:15:34 +0000 > From: Alan Mackenzie > > In my initial investigation of bug #19706, an immediate cause of the > failure is clear - `frameset-move-onscreen' executes: > > (frame-parameter frame 'left) > > , but on a tty this parameter is nil. This is insanity, and was an > accident waiting to happen (it has now happened). Code that accesses frame parameters should expect any particular parameter to appear there, it should be resistant in the face of alist elements missing completely. There are many more frame parameters that will never be present in a parameters alist of TTY frames (or any other frame, for that matter). > The correct values of frame parameters 'left and 'top on a tty cannot be > other than 0. Yes, and since a TTY frame cannot be moved anyway, the code in question should already make a special case for such frames. > There are two ways of fixing bug #19706: > > The first is to put in special case handling for missing frame > parameters, pray that the same error isn't already programmed into our > source anywhere else, and trust our highly skilled hackers never to > blunder into the same trap again. > > The second is to set the frame parameters appropriately for tty's. > > I think I've made it obvious which course I prefer. I hope I explained why I disagree with you.