* Apparent regression on the undo command @ 2015-11-18 11:50 Artur Malabarba 2015-11-18 12:24 ` Phillip Lord 2015-11-18 22:50 ` Markus Triska 0 siblings, 2 replies; 24+ messages in thread From: Artur Malabarba @ 2015-11-18 11:50 UTC (permalink / raw) To: emacs-devel I've been noticing this for days now. Whenever I invoke `undo' (C-/), the last change is correctly undone but then sometimes the cursor gets moved apparently random places in the buffer. It took me a couple of days to realise it was moving point to the position of my "penultimate" change (the change before the one I just undid). Is this intentional? I don't see anything about on the NEWS. If so, is there a way to disable it? Cheers, Artur ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: Apparent regression on the undo command 2015-11-18 11:50 Apparent regression on the undo command Artur Malabarba @ 2015-11-18 12:24 ` Phillip Lord 2015-11-18 13:16 ` Artur Malabarba 2015-11-18 22:50 ` Markus Triska 1 sibling, 1 reply; 24+ messages in thread From: Phillip Lord @ 2015-11-18 12:24 UTC (permalink / raw) To: Artur Malabarba; +Cc: emacs-devel Artur Malabarba <bruce.connor.am@gmail.com> writes: > I've been noticing this for days now. Whenever I invoke `undo' (C-/), > the last change is correctly undone but then sometimes the cursor gets > moved apparently random places in the buffer. > > It took me a couple of days to realise it was moving point to the > position of my "penultimate" change (the change before the one I just > undid). > > Is this intentional? I don't see anything about on the NEWS. > If so, is there a way to disable it? Almost certainly my fault, and caused by commit 44dfa86b7. Anything that you can do to make it repeatable would be excellent. If you cannot make it repeatable, it would be good to know that also. Also, can you try: (setq undo-auto--current-boundary-timer t) and see if that stops it. Phil ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: Apparent regression on the undo command 2015-11-18 12:24 ` Phillip Lord @ 2015-11-18 13:16 ` Artur Malabarba 2015-11-19 9:47 ` Phillip Lord 0 siblings, 1 reply; 24+ messages in thread From: Artur Malabarba @ 2015-11-18 13:16 UTC (permalink / raw) To: Phillip Lord; +Cc: emacs-devel > Anything that you can do to make it repeatable would be excellent. If > you cannot make it repeatable, it would be good to know that also. 1. Start emacs -Q 2. Delete the word "buffer" 3. Move up a couple of lines, and delete the word "want". 4. undo 5. Point will be left at where you deleted the word "buffer". > Also, can you try: > > (setq undo-auto--current-boundary-timer t) > > and see if that stops it. No. Still same thing. Best, ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: Apparent regression on the undo command 2015-11-18 13:16 ` Artur Malabarba @ 2015-11-19 9:47 ` Phillip Lord 2015-11-19 12:11 ` Artur Malabarba 0 siblings, 1 reply; 24+ messages in thread From: Phillip Lord @ 2015-11-19 9:47 UTC (permalink / raw) To: Artur Malabarba; +Cc: emacs-devel Artur Malabarba <bruce.connor.am@gmail.com> writes: >> Anything that you can do to make it repeatable would be excellent. If >> you cannot make it repeatable, it would be good to know that also. > > 1. Start emacs -Q > 2. Delete the word "buffer" > 3. Move up a couple of lines, and delete the word "want". > 4. undo > 5. Point will be left at where you deleted the word "buffer". > >> Also, can you try: >> >> (setq undo-auto--current-boundary-timer t) >> >> and see if that stops it. > > No. Still same thing. So, I've tested, and this problem is not caused by patch after all, but sometime since 24.5. I'll try and see if I can automate the problem and run a bisect. Phil ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: Apparent regression on the undo command 2015-11-19 9:47 ` Phillip Lord @ 2015-11-19 12:11 ` Artur Malabarba 2015-11-19 13:12 ` Phillip Lord 0 siblings, 1 reply; 24+ messages in thread From: Artur Malabarba @ 2015-11-19 12:11 UTC (permalink / raw) To: Phillip Lord; +Cc: emacs-devel 2015-11-19 9:47 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: > I'll try and see if I can automate the problem and > run a bisect. The following works for me. When called on the *scratch* buffer it returns non-nil if the problem occurs. (progn (kmacro-call-macro nil nil nil [134217788 11 14 14 11 67108911]) (equal (point-min) (point))) That macro simply calls M-< C-k C-n C-n C-k C-/ ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: Apparent regression on the undo command 2015-11-19 12:11 ` Artur Malabarba @ 2015-11-19 13:12 ` Phillip Lord 2015-11-20 1:24 ` Karl Fogel 0 siblings, 1 reply; 24+ messages in thread From: Phillip Lord @ 2015-11-19 13:12 UTC (permalink / raw) To: Artur Malabarba; +Cc: emacs-devel Artur Malabarba <bruce.connor.am@gmail.com> writes: > 2015-11-19 9:47 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: >> I'll try and see if I can automate the problem and >> run a bisect. > > The following works for me. When called on the *scratch* buffer it > returns non-nil if the problem occurs. > > (progn > (kmacro-call-macro nil nil nil [134217788 11 14 14 11 67108911]) > (equal (point-min) (point))) > > That macro simply calls M-< C-k C-n C-n C-k C-/ I tried various combinations -- works interactively but fails in batch either because *scratch* hasn't been initialized, or undo appears to work wrongly. No worries, it's easy enough to test by hand, and am doing so. Phil ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: Apparent regression on the undo command 2015-11-19 13:12 ` Phillip Lord @ 2015-11-20 1:24 ` Karl Fogel 2015-11-20 7:51 ` Phillip Lord 0 siblings, 1 reply; 24+ messages in thread From: Karl Fogel @ 2015-11-20 1:24 UTC (permalink / raw) To: Phillip Lord; +Cc: Artur Malabarba, emacs-devel phillip.lord@russet.org.uk (Phillip Lord) writes: >Artur Malabarba <bruce.connor.am@gmail.com> writes: >> 2015-11-19 9:47 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: >>> I'll try and see if I can automate the problem and >>> run a bisect. >> >> The following works for me. When called on the *scratch* buffer it >> returns non-nil if the problem occurs. >> >> (progn >> (kmacro-call-macro nil nil nil [134217788 11 14 14 11 67108911]) >> (equal (point-min) (point))) >> >> That macro simply calls M-< C-k C-n C-n C-k C-/ > > >I tried various combinations -- works interactively but fails in batch >either because *scratch* hasn't been initialized, or undo appears to >work wrongly. > >No worries, it's easy enough to test by hand, and am doing so. Any luck? FWIW I'm noticing the bug too, in emacs-25 branch built from commit c210b8b128c. Best regards, -Karl ^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: Apparent regression on the undo command 2015-11-20 1:24 ` Karl Fogel @ 2015-11-20 7:51 ` Phillip Lord 2015-11-20 10:06 ` Artur Malabarba 0 siblings, 1 reply; 24+ messages in thread From: Phillip Lord @ 2015-11-20 7:51 UTC (permalink / raw) To: Karl Fogel, Phillip Lord; +Cc: Artur Malabarba, emacs-devel It is my commit after all. I will work on it as soon as I can. Had a nasty cold for the last few days. Phil ________________________________________ From: emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org [emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org] on behalf of Karl Fogel [kfogel@red-bean.com] Sent: 20 November 2015 01:24 To: Phillip Lord Cc: Artur Malabarba; emacs-devel Subject: Re: Apparent regression on the undo command phillip.lord@russet.org.uk (Phillip Lord) writes: >Artur Malabarba <bruce.connor.am@gmail.com> writes: >> 2015-11-19 9:47 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: >>> I'll try and see if I can automate the problem and >>> run a bisect. >> >> The following works for me. When called on the *scratch* buffer it >> returns non-nil if the problem occurs. >> >> (progn >> (kmacro-call-macro nil nil nil [134217788 11 14 14 11 67108911]) >> (equal (point-min) (point))) >> >> That macro simply calls M-< C-k C-n C-n C-k C-/ > > >I tried various combinations -- works interactively but fails in batch >either because *scratch* hasn't been initialized, or undo appears to >work wrongly. > >No worries, it's easy enough to test by hand, and am doing so. Any luck? FWIW I'm noticing the bug too, in emacs-25 branch built from commit c210b8b128c. Best regards, -Karl ^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: Apparent regression on the undo command 2015-11-20 7:51 ` Phillip Lord @ 2015-11-20 10:06 ` Artur Malabarba 2015-11-21 10:02 ` Phillip Lord 0 siblings, 1 reply; 24+ messages in thread From: Artur Malabarba @ 2015-11-20 10:06 UTC (permalink / raw) To: Phillip Lord; +Cc: Karl Fogel, Phillip Lord, emacs-devel [-- Attachment #1: Type: text/plain, Size: 1533 bytes --] No problem Phil. Thanks for looking into this. On 20 Nov 2015 7:51 am, "Phillip Lord" <phillip.lord@newcastle.ac.uk> wrote: > > It is my commit after all. I will work on it as soon as I can. Had a nasty > cold for the last few days. > > Phil > ________________________________________ > From: emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org > [emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org] on behalf of > Karl Fogel [kfogel@red-bean.com] > Sent: 20 November 2015 01:24 > To: Phillip Lord > Cc: Artur Malabarba; emacs-devel > Subject: Re: Apparent regression on the undo command > > phillip.lord@russet.org.uk (Phillip Lord) writes: > >Artur Malabarba <bruce.connor.am@gmail.com> writes: > >> 2015-11-19 9:47 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: > >>> I'll try and see if I can automate the problem and > >>> run a bisect. > >> > >> The following works for me. When called on the *scratch* buffer it > >> returns non-nil if the problem occurs. > >> > >> (progn > >> (kmacro-call-macro nil nil nil [134217788 11 14 14 11 67108911]) > >> (equal (point-min) (point))) > >> > >> That macro simply calls M-< C-k C-n C-n C-k C-/ > > > > > >I tried various combinations -- works interactively but fails in batch > >either because *scratch* hasn't been initialized, or undo appears to > >work wrongly. > > > >No worries, it's easy enough to test by hand, and am doing so. > > Any luck? FWIW I'm noticing the bug too, in emacs-25 branch built from > commit c210b8b128c. > > Best regards, > -Karl > > [-- Attachment #2: Type: text/html, Size: 2315 bytes --] ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: Apparent regression on the undo command 2015-11-20 10:06 ` Artur Malabarba @ 2015-11-21 10:02 ` Phillip Lord 2015-11-21 11:18 ` Artur Malabarba 0 siblings, 1 reply; 24+ messages in thread From: Phillip Lord @ 2015-11-21 10:02 UTC (permalink / raw) To: Artur Malabarba; +Cc: Karl Fogel, emacs-devel I have a possible fix for this now, currently on the branch fix/undo-point-in-wrong-place. I waiting for some other feedback on my code before I squash and merge it, but if you have the chance it would be good to know if it works. Phil Artur Malabarba <bruce.connor.am@gmail.com> writes: > No problem Phil. > Thanks for looking into this. > On 20 Nov 2015 7:51 am, "Phillip Lord" <phillip.lord@newcastle.ac.uk> wrote: > >> >> It is my commit after all. I will work on it as soon as I can. Had a nasty >> cold for the last few days. >> >> Phil >> ________________________________________ >> From: emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org >> [emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org] on behalf of >> Karl Fogel [kfogel@red-bean.com] >> Sent: 20 November 2015 01:24 >> To: Phillip Lord >> Cc: Artur Malabarba; emacs-devel >> Subject: Re: Apparent regression on the undo command >> >> phillip.lord@russet.org.uk (Phillip Lord) writes: >> >Artur Malabarba <bruce.connor.am@gmail.com> writes: >> >> 2015-11-19 9:47 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: >> >>> I'll try and see if I can automate the problem and >> >>> run a bisect. >> >> >> >> The following works for me. When called on the *scratch* buffer it >> >> returns non-nil if the problem occurs. >> >> >> >> (progn >> >> (kmacro-call-macro nil nil nil [134217788 11 14 14 11 67108911]) >> >> (equal (point-min) (point))) >> >> >> >> That macro simply calls M-< C-k C-n C-n C-k C-/ >> > >> > >> >I tried various combinations -- works interactively but fails in batch >> >either because *scratch* hasn't been initialized, or undo appears to >> >work wrongly. >> > >> >No worries, it's easy enough to test by hand, and am doing so. >> >> Any luck? FWIW I'm noticing the bug too, in emacs-25 branch built from >> commit c210b8b128c. >> >> Best regards, >> -Karl >> >> ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: Apparent regression on the undo command 2015-11-21 10:02 ` Phillip Lord @ 2015-11-21 11:18 ` Artur Malabarba 2015-11-22 0:55 ` bug#21968: " David Reitter 2015-11-22 0:55 ` David Reitter 0 siblings, 2 replies; 24+ messages in thread From: Artur Malabarba @ 2015-11-21 11:18 UTC (permalink / raw) To: Phillip Lord; +Cc: Karl Fogel, emacs-devel [-- Attachment #1: Type: text/plain, Size: 2159 bytes --] I can't speak for the code, but I just tested your fix and looks like it works. Thanks Phil. 2015-11-21 10:02 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: > > I have a possible fix for this now, currently on the > branch fix/undo-point-in-wrong-place. I waiting for some other feedback > on my code before I squash and merge it, but if you have the chance it > would be good to know if it works. > > Phil > > > Artur Malabarba <bruce.connor.am@gmail.com> writes: > > > No problem Phil. > > Thanks for looking into this. > > On 20 Nov 2015 7:51 am, "Phillip Lord" <phillip.lord@newcastle.ac.uk> > wrote: > > > >> > >> It is my commit after all. I will work on it as soon as I can. Had a > nasty > >> cold for the last few days. > >> > >> Phil > >> ________________________________________ > >> From: emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org > >> [emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org] on behalf of > >> Karl Fogel [kfogel@red-bean.com] > >> Sent: 20 November 2015 01:24 > >> To: Phillip Lord > >> Cc: Artur Malabarba; emacs-devel > >> Subject: Re: Apparent regression on the undo command > >> > >> phillip.lord@russet.org.uk (Phillip Lord) writes: > >> >Artur Malabarba <bruce.connor.am@gmail.com> writes: > >> >> 2015-11-19 9:47 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: > >> >>> I'll try and see if I can automate the problem and > >> >>> run a bisect. > >> >> > >> >> The following works for me. When called on the *scratch* buffer it > >> >> returns non-nil if the problem occurs. > >> >> > >> >> (progn > >> >> (kmacro-call-macro nil nil nil [134217788 11 14 14 11 67108911]) > >> >> (equal (point-min) (point))) > >> >> > >> >> That macro simply calls M-< C-k C-n C-n C-k C-/ > >> > > >> > > >> >I tried various combinations -- works interactively but fails in batch > >> >either because *scratch* hasn't been initialized, or undo appears to > >> >work wrongly. > >> > > >> >No worries, it's easy enough to test by hand, and am doing so. > >> > >> Any luck? FWIW I'm noticing the bug too, in emacs-25 branch built from > >> commit c210b8b128c. > >> > >> Best regards, > >> -Karl > >> > >> > [-- Attachment #2: Type: text/html, Size: 3510 bytes --] ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#21968: Apparent regression on the undo command 2015-11-21 11:18 ` Artur Malabarba @ 2015-11-22 0:55 ` David Reitter 2015-11-22 0:55 ` David Reitter 1 sibling, 0 replies; 24+ messages in thread From: David Reitter @ 2015-11-22 0:55 UTC (permalink / raw) To: Phillip Lord; +Cc: 21968, emacs-devel Phil, I tried your fix. It works for backward-kill-word, but for kill-word (forward), the cursor ends up in the wrong place (after the word, not where it was initially). - David > On Nov 21, 2015, at 6:18 AM, Artur Malabarba <bruce.connor.am@gmail.com> wrote: > > I can't speak for the code, but I just tested your fix and looks like it works. > > Thanks Phil. > > 2015-11-21 10:02 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: > > I have a possible fix for this now, currently on the > branch fix/undo-point-in-wrong-place. I waiting for some other feedback > on my code before I squash and merge it, but if you have the chance it > would be good to know if it works. > > Phil > > > Artur Malabarba <bruce.connor.am@gmail.com> writes: > > > No problem Phil. > > Thanks for looking into this. > > On 20 Nov 2015 7:51 am, "Phillip Lord" <phillip.lord@newcastle.ac.uk> wrote: > > > >> > >> It is my commit after all. I will work on it as soon as I can. Had a nasty > >> cold for the last few days. > >> > >> Phil > >> ________________________________________ > >> From: emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org > >> [emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org] on behalf of > >> Karl Fogel [kfogel@red-bean.com] > >> Sent: 20 November 2015 01:24 > >> To: Phillip Lord > >> Cc: Artur Malabarba; emacs-devel > >> Subject: Re: Apparent regression on the undo command > >> > >> phillip.lord@russet.org.uk (Phillip Lord) writes: > >> >Artur Malabarba <bruce.connor.am@gmail.com> writes: > >> >> 2015-11-19 9:47 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: > >> >>> I'll try and see if I can automate the problem and > >> >>> run a bisect. > >> >> > >> >> The following works for me. When called on the *scratch* buffer it > >> >> returns non-nil if the problem occurs. > >> >> > >> >> (progn > >> >> (kmacro-call-macro nil nil nil [134217788 11 14 14 11 67108911]) > >> >> (equal (point-min) (point))) > >> >> > >> >> That macro simply calls M-< C-k C-n C-n C-k C-/ > >> > > >> > > >> >I tried various combinations -- works interactively but fails in batch > >> >either because *scratch* hasn't been initialized, or undo appears to > >> >work wrongly. > >> > > >> >No worries, it's easy enough to test by hand, and am doing so. > >> > >> Any luck? FWIW I'm noticing the bug too, in emacs-25 branch built from > >> commit c210b8b128c. > >> > >> Best regards, > >> -Karl > >> > >> > ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: Apparent regression on the undo command 2015-11-21 11:18 ` Artur Malabarba 2015-11-22 0:55 ` bug#21968: " David Reitter @ 2015-11-22 0:55 ` David Reitter 2015-11-23 17:27 ` Phillip Lord 2015-11-23 17:27 ` Phillip Lord 1 sibling, 2 replies; 24+ messages in thread From: David Reitter @ 2015-11-22 0:55 UTC (permalink / raw) To: Phillip Lord; +Cc: 21968, emacs-devel Phil, I tried your fix. It works for backward-kill-word, but for kill-word (forward), the cursor ends up in the wrong place (after the word, not where it was initially). - David > On Nov 21, 2015, at 6:18 AM, Artur Malabarba <bruce.connor.am@gmail.com> wrote: > > I can't speak for the code, but I just tested your fix and looks like it works. > > Thanks Phil. > > 2015-11-21 10:02 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: > > I have a possible fix for this now, currently on the > branch fix/undo-point-in-wrong-place. I waiting for some other feedback > on my code before I squash and merge it, but if you have the chance it > would be good to know if it works. > > Phil > > > Artur Malabarba <bruce.connor.am@gmail.com> writes: > > > No problem Phil. > > Thanks for looking into this. > > On 20 Nov 2015 7:51 am, "Phillip Lord" <phillip.lord@newcastle.ac.uk> wrote: > > > >> > >> It is my commit after all. I will work on it as soon as I can. Had a nasty > >> cold for the last few days. > >> > >> Phil > >> ________________________________________ > >> From: emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org > >> [emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org] on behalf of > >> Karl Fogel [kfogel@red-bean.com] > >> Sent: 20 November 2015 01:24 > >> To: Phillip Lord > >> Cc: Artur Malabarba; emacs-devel > >> Subject: Re: Apparent regression on the undo command > >> > >> phillip.lord@russet.org.uk (Phillip Lord) writes: > >> >Artur Malabarba <bruce.connor.am@gmail.com> writes: > >> >> 2015-11-19 9:47 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: > >> >>> I'll try and see if I can automate the problem and > >> >>> run a bisect. > >> >> > >> >> The following works for me. When called on the *scratch* buffer it > >> >> returns non-nil if the problem occurs. > >> >> > >> >> (progn > >> >> (kmacro-call-macro nil nil nil [134217788 11 14 14 11 67108911]) > >> >> (equal (point-min) (point))) > >> >> > >> >> That macro simply calls M-< C-k C-n C-n C-k C-/ > >> > > >> > > >> >I tried various combinations -- works interactively but fails in batch > >> >either because *scratch* hasn't been initialized, or undo appears to > >> >work wrongly. > >> > > >> >No worries, it's easy enough to test by hand, and am doing so. > >> > >> Any luck? FWIW I'm noticing the bug too, in emacs-25 branch built from > >> commit c210b8b128c. > >> > >> Best regards, > >> -Karl > >> > >> > ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: Apparent regression on the undo command 2015-11-22 0:55 ` David Reitter @ 2015-11-23 17:27 ` Phillip Lord 2015-12-14 20:04 ` bug#21968: " John Wiegley 2015-11-23 17:27 ` Phillip Lord 1 sibling, 1 reply; 24+ messages in thread From: Phillip Lord @ 2015-11-23 17:27 UTC (permalink / raw) To: David Reitter; +Cc: 21968, emacs-devel Okay, am working on this now! David Reitter <david.reitter@gmail.com> writes: > Phil, > > I tried your fix. It works for backward-kill-word, but for kill-word > (forward), the cursor ends up in the wrong place (after the word, not where it > was initially). > > - David > > >> On Nov 21, 2015, at 6:18 AM, Artur Malabarba <bruce.connor.am@gmail.com> wrote: >> >> I can't speak for the code, but I just tested your fix and looks like it works. >> >> Thanks Phil. >> >> 2015-11-21 10:02 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: >> >> I have a possible fix for this now, currently on the >> branch fix/undo-point-in-wrong-place. I waiting for some other feedback >> on my code before I squash and merge it, but if you have the chance it >> would be good to know if it works. >> >> Phil >> >> >> Artur Malabarba <bruce.connor.am@gmail.com> writes: >> >> > No problem Phil. >> > Thanks for looking into this. >> > On 20 Nov 2015 7:51 am, "Phillip Lord" <phillip.lord@newcastle.ac.uk> wrote: >> > >> >> >> >> It is my commit after all. I will work on it as soon as I can. Had a nasty >> >> cold for the last few days. >> >> >> >> Phil >> >> ________________________________________ >> >> From: emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org >> >> [emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org] on behalf of >> >> Karl Fogel [kfogel@red-bean.com] >> >> Sent: 20 November 2015 01:24 >> >> To: Phillip Lord >> >> Cc: Artur Malabarba; emacs-devel >> >> Subject: Re: Apparent regression on the undo command >> >> >> >> phillip.lord@russet.org.uk (Phillip Lord) writes: >> >> >Artur Malabarba <bruce.connor.am@gmail.com> writes: >> >> >> 2015-11-19 9:47 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: >> >> >>> I'll try and see if I can automate the problem and >> >> >>> run a bisect. >> >> >> >> >> >> The following works for me. When called on the *scratch* buffer it >> >> >> returns non-nil if the problem occurs. >> >> >> >> >> >> (progn >> >> >> (kmacro-call-macro nil nil nil [134217788 11 14 14 11 67108911]) >> >> >> (equal (point-min) (point))) >> >> >> >> >> >> That macro simply calls M-< C-k C-n C-n C-k C-/ >> >> > >> >> > >> >> >I tried various combinations -- works interactively but fails in batch >> >> >either because *scratch* hasn't been initialized, or undo appears to >> >> >work wrongly. >> >> > >> >> >No worries, it's easy enough to test by hand, and am doing so. >> >> >> >> Any luck? FWIW I'm noticing the bug too, in emacs-25 branch built from >> >> commit c210b8b128c. >> >> >> >> Best regards, >> >> -Karl >> >> >> >> >> ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#21968: Apparent regression on the undo command 2015-11-23 17:27 ` Phillip Lord @ 2015-12-14 20:04 ` John Wiegley 2015-12-14 20:09 ` Eli Zaretskii 0 siblings, 1 reply; 24+ messages in thread From: John Wiegley @ 2015-12-14 20:04 UTC (permalink / raw) To: Phillip Lord; +Cc: David Reitter, 21968 >>>>> Phillip Lord <phillip.lord@russet.org.uk> writes: > Okay, am working on this now! Hi Phil, I just built emacs-25, but most actions that I take give me errors like the following: Symbol’s function definition is void: undo-auto-amalgamate Have I omitted to do something? -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#21968: Apparent regression on the undo command 2015-12-14 20:04 ` bug#21968: " John Wiegley @ 2015-12-14 20:09 ` Eli Zaretskii 2015-12-14 21:28 ` Phillip Lord 0 siblings, 1 reply; 24+ messages in thread From: Eli Zaretskii @ 2015-12-14 20:09 UTC (permalink / raw) To: John Wiegley; +Cc: david.reitter, phillip.lord, 21968 > From: John Wiegley <jwiegley@gmail.com> > Date: Mon, 14 Dec 2015 12:04:59 -0800 > Cc: David Reitter <david.reitter@gmail.com>, 21968@debbugs.gnu.org > > I just built emacs-25, but most actions that I take give me errors like the > following: > > Symbol’s function definition is void: undo-auto-amalgamate > > Have I omitted to do something? I don't know, but that function is in simple.el. Did you build in a clean directory? ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#21968: Apparent regression on the undo command 2015-12-14 20:09 ` Eli Zaretskii @ 2015-12-14 21:28 ` Phillip Lord 2015-12-14 22:05 ` John Wiegley 0 siblings, 1 reply; 24+ messages in thread From: Phillip Lord @ 2015-12-14 21:28 UTC (permalink / raw) To: Eli Zaretskii; +Cc: John Wiegley, david.reitter, 21968 Eli Zaretskii <eliz@gnu.org> writes: >> From: John Wiegley <jwiegley@gmail.com> >> Date: Mon, 14 Dec 2015 12:04:59 -0800 >> Cc: David Reitter <david.reitter@gmail.com>, 21968@debbugs.gnu.org >> >> I just built emacs-25, but most actions that I take give me errors like the >> following: >> >> Symbol’s function definition is void: undo-auto-amalgamate >> >> Have I omitted to do something? > > I don't know, but that function is in simple.el. Did you build in a > clean directory? I'd suspect a clean build here, also. I introduced undo-auto-amalgamate in eaa1fd6d. Phil ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#21968: Apparent regression on the undo command 2015-12-14 21:28 ` Phillip Lord @ 2015-12-14 22:05 ` John Wiegley 2015-12-14 22:30 ` Phillip Lord 0 siblings, 1 reply; 24+ messages in thread From: John Wiegley @ 2015-12-14 22:05 UTC (permalink / raw) To: Phillip Lord; +Cc: John Wiegley, david.reitter, 21968 >>>>> Phillip Lord <phillip.lord@russet.org.uk> writes: >> I don't know, but that function is in simple.el. Did you build in a >> clean directory? > I'd suspect a clean build here, also. I introduced undo-auto-amalgamate in > eaa1fd6d. Hmm.. I'm building with Nix, which should by definition mean always having a clean environment. I'll look into it further. Thanks, -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#21968: Apparent regression on the undo command 2015-12-14 22:05 ` John Wiegley @ 2015-12-14 22:30 ` Phillip Lord 2015-12-14 22:34 ` John Wiegley 0 siblings, 1 reply; 24+ messages in thread From: Phillip Lord @ 2015-12-14 22:30 UTC (permalink / raw) To: John Wiegley; +Cc: david.reitter, 21968 John Wiegley <jwiegley@gmail.com> writes: >>>>>> Phillip Lord <phillip.lord@russet.org.uk> writes: > >>> I don't know, but that function is in simple.el. Did you build in a >>> clean directory? > >> I'd suspect a clean build here, also. I introduced undo-auto-amalgamate in >> eaa1fd6d. > > Hmm.. I'm building with Nix, which should by definition mean always having a > clean environment. I'll look into it further. My guess would be that the src directory has build, but simple.elc was not. Never used nix, am afraid. Phil ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#21968: Apparent regression on the undo command 2015-12-14 22:30 ` Phillip Lord @ 2015-12-14 22:34 ` John Wiegley 2015-12-15 9:31 ` Phillip Lord 0 siblings, 1 reply; 24+ messages in thread From: John Wiegley @ 2015-12-14 22:34 UTC (permalink / raw) To: Phillip Lord; +Cc: david.reitter, 21968 >>>>> Phillip Lord <phillip.lord@russet.org.uk> writes: > My guess would be that the src directory has build, but simple.elc was not. > Never used nix, am afraid. I can confirm after installation that the source file had the function defined in it, but the compiled version did not. I've changed the Nix build expression to explicitly remove all .elc files, to force a clean rebuild each time. It's going much more slowly now, which is heartening. -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#21968: Apparent regression on the undo command 2015-12-14 22:34 ` John Wiegley @ 2015-12-15 9:31 ` Phillip Lord 2015-12-15 15:06 ` John Wiegley 0 siblings, 1 reply; 24+ messages in thread From: Phillip Lord @ 2015-12-15 9:31 UTC (permalink / raw) To: John Wiegley; +Cc: david.reitter, 21968 John Wiegley <jwiegley@gmail.com> writes: >>>>>> Phillip Lord <phillip.lord@russet.org.uk> writes: > >> My guess would be that the src directory has build, but simple.elc was not. >> Never used nix, am afraid. > > I can confirm after installation that the source file had the function defined > in it, but the compiled version did not. I've changed the Nix build expression > to explicitly remove all .elc files, to force a clean rebuild each time. It's > going much more slowly now, which is heartening. Well there is a turn up -- someone who is happy that the build is getting slower! I think that this issue is probably complete now. Anyone know how to close it? Phil ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#21968: Apparent regression on the undo command 2015-12-15 9:31 ` Phillip Lord @ 2015-12-15 15:06 ` John Wiegley 0 siblings, 0 replies; 24+ messages in thread From: John Wiegley @ 2015-12-15 15:06 UTC (permalink / raw) To: Phillip Lord; +Cc: david.reitter, 21968-done >>>>> Phillip Lord <phillip.lord@russet.org.uk> writes: > I think that this issue is probably complete now. Anyone know how to close > it? Closed (by appending "-done" to the bug id in the e-mail addr). -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 ^ permalink raw reply [flat|nested] 24+ messages in thread
* bug#21968: Apparent regression on the undo command 2015-11-22 0:55 ` David Reitter 2015-11-23 17:27 ` Phillip Lord @ 2015-11-23 17:27 ` Phillip Lord 1 sibling, 0 replies; 24+ messages in thread From: Phillip Lord @ 2015-11-23 17:27 UTC (permalink / raw) To: David Reitter; +Cc: 21968, emacs-devel Okay, am working on this now! David Reitter <david.reitter@gmail.com> writes: > Phil, > > I tried your fix. It works for backward-kill-word, but for kill-word > (forward), the cursor ends up in the wrong place (after the word, not where it > was initially). > > - David > > >> On Nov 21, 2015, at 6:18 AM, Artur Malabarba <bruce.connor.am@gmail.com> wrote: >> >> I can't speak for the code, but I just tested your fix and looks like it works. >> >> Thanks Phil. >> >> 2015-11-21 10:02 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: >> >> I have a possible fix for this now, currently on the >> branch fix/undo-point-in-wrong-place. I waiting for some other feedback >> on my code before I squash and merge it, but if you have the chance it >> would be good to know if it works. >> >> Phil >> >> >> Artur Malabarba <bruce.connor.am@gmail.com> writes: >> >> > No problem Phil. >> > Thanks for looking into this. >> > On 20 Nov 2015 7:51 am, "Phillip Lord" <phillip.lord@newcastle.ac.uk> wrote: >> > >> >> >> >> It is my commit after all. I will work on it as soon as I can. Had a nasty >> >> cold for the last few days. >> >> >> >> Phil >> >> ________________________________________ >> >> From: emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org >> >> [emacs-devel-bounces+phillip.lord=newcastle.ac.uk@gnu.org] on behalf of >> >> Karl Fogel [kfogel@red-bean.com] >> >> Sent: 20 November 2015 01:24 >> >> To: Phillip Lord >> >> Cc: Artur Malabarba; emacs-devel >> >> Subject: Re: Apparent regression on the undo command >> >> >> >> phillip.lord@russet.org.uk (Phillip Lord) writes: >> >> >Artur Malabarba <bruce.connor.am@gmail.com> writes: >> >> >> 2015-11-19 9:47 GMT+00:00 Phillip Lord <phillip.lord@russet.org.uk>: >> >> >>> I'll try and see if I can automate the problem and >> >> >>> run a bisect. >> >> >> >> >> >> The following works for me. When called on the *scratch* buffer it >> >> >> returns non-nil if the problem occurs. >> >> >> >> >> >> (progn >> >> >> (kmacro-call-macro nil nil nil [134217788 11 14 14 11 67108911]) >> >> >> (equal (point-min) (point))) >> >> >> >> >> >> That macro simply calls M-< C-k C-n C-n C-k C-/ >> >> > >> >> > >> >> >I tried various combinations -- works interactively but fails in batch >> >> >either because *scratch* hasn't been initialized, or undo appears to >> >> >work wrongly. >> >> > >> >> >No worries, it's easy enough to test by hand, and am doing so. >> >> >> >> Any luck? FWIW I'm noticing the bug too, in emacs-25 branch built from >> >> commit c210b8b128c. >> >> >> >> Best regards, >> >> -Karl >> >> >> >> >> ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: Apparent regression on the undo command 2015-11-18 11:50 Apparent regression on the undo command Artur Malabarba 2015-11-18 12:24 ` Phillip Lord @ 2015-11-18 22:50 ` Markus Triska 1 sibling, 0 replies; 24+ messages in thread From: Markus Triska @ 2015-11-18 22:50 UTC (permalink / raw) To: Artur Malabarba; +Cc: emacs-devel Hi Artur, Artur Malabarba <bruce.connor.am@gmail.com> writes: > I've been noticing this for days now. Whenever I invoke `undo' (C-/), > the last change is correctly undone but then sometimes the cursor gets > moved apparently random places in the buffer. > > It took me a couple of days to realise it was moving point to the > position of my "penultimate" change (the change before the one I just > undid). Issue #21722 may be related to this: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=21722 I began noticing unexpected point positions after undo starting with Emacs 23.1. I cannot reproduce the regression consistently, and it only occurs sporadically, but I hope that this helps to get to the root cause of such problems. All the best! Markus ^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2015-12-15 15:06 UTC | newest] Thread overview: 24+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-11-18 11:50 Apparent regression on the undo command Artur Malabarba 2015-11-18 12:24 ` Phillip Lord 2015-11-18 13:16 ` Artur Malabarba 2015-11-19 9:47 ` Phillip Lord 2015-11-19 12:11 ` Artur Malabarba 2015-11-19 13:12 ` Phillip Lord 2015-11-20 1:24 ` Karl Fogel 2015-11-20 7:51 ` Phillip Lord 2015-11-20 10:06 ` Artur Malabarba 2015-11-21 10:02 ` Phillip Lord 2015-11-21 11:18 ` Artur Malabarba 2015-11-22 0:55 ` bug#21968: " David Reitter 2015-11-22 0:55 ` David Reitter 2015-11-23 17:27 ` Phillip Lord 2015-12-14 20:04 ` bug#21968: " John Wiegley 2015-12-14 20:09 ` Eli Zaretskii 2015-12-14 21:28 ` Phillip Lord 2015-12-14 22:05 ` John Wiegley 2015-12-14 22:30 ` Phillip Lord 2015-12-14 22:34 ` John Wiegley 2015-12-15 9:31 ` Phillip Lord 2015-12-15 15:06 ` John Wiegley 2015-11-23 17:27 ` Phillip Lord 2015-11-18 22:50 ` Markus Triska
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.