all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Leo Liu <sdl.web@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Can we not introduce frivolous indentation change to define-minor-mode?
Date: Thu, 07 Jan 2016 21:05:37 +0200	[thread overview]
Message-ID: <83vb751a7y.fsf@gnu.org> (raw)
In-Reply-To: <m137u9i5s1.fsf@gmail.com> (message from Leo Liu on Fri, 08 Jan 2016 02:49:34 +0800)

> From: Leo Liu <sdl.web@gmail.com>
> Date: Fri, 08 Jan 2016 02:49:34 +0800
> 
> >> I'm sorry, but the practice of unilaterally reverting commits of others
> >> seems unkind to me. I think we should refrain from making changes which are
> >> under dispute, where the parties have not yet reached an agreement. Doing so
> >> causes aggravation and animosity we'd better without.
> >
> >> John, WDYT?
> >
> > 100% agreement.
> 
> No disagreement here.
> 
> I don't intend to appear unkind or anything like that. I hope my message
> doesn't suggest that.
> 
> I have weighted on the comments provided and taken the action
> accordingly based on the fact that it is an incompatible change and
> controversial on a few points.

I'm sure you have considered the issue before reverting.

However, my point is that you should have refrained from that until
the discussion concluded in an agreement.  If no agreement could be
reached, and no acceptable compromise was in sight, the proper way,
IMO, would be to ask John to suggest a compromise or make a decision.
This way, all the involved parties will at least have an opportunity
to present their case, and will feel that due process has been done.

Thanks.



      parent reply	other threads:[~2016-01-07 19:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05 12:32 Can we not introduce frivolous indentation change to define-minor-mode? Leo Liu
2016-01-05 16:09 ` Eli Zaretskii
2016-01-05 23:11   ` Leo Liu
2016-01-06  9:14     ` Oleh Krehel
2016-01-06 11:50       ` Leo Liu
2016-01-06 12:38         ` Oleh Krehel
2016-01-06 13:42           ` Artur Malabarba
2016-01-06 13:56             ` Oleh Krehel
2016-01-06 14:33               ` Artur Malabarba
2016-01-06 15:37               ` Jonas Bernoulli
2016-01-06 15:48                 ` Oleh Krehel
2016-01-06 15:54                   ` Dmitry Gutov
2016-01-06 16:02                     ` Oleh Krehel
2016-01-07  1:54                       ` Leo Liu
2016-01-07 16:09                         ` Eli Zaretskii
2016-01-07 17:58                           ` John Wiegley
2016-01-07 18:49                             ` Leo Liu
2016-01-07 19:00                               ` John Wiegley
2016-01-07 19:40                                 ` Leo Liu
2016-01-07 19:05                               ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83vb751a7y.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.