all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <f92capac@gmail.com>
Cc: 23206@debbugs.gnu.org
Subject: bug#23206: 25.0.92; dired-shell-stuff-it: wait until all parallel jobs finish
Date: Tue, 05 Apr 2016 17:59:22 +0300	[thread overview]
Message-ID: <83vb3wm791.fsf@gnu.org> (raw)
In-Reply-To: <alpine.LRH.2.20.1604051423310.9018@calancha-ilc.kek.jp> (message from Tino Calancha on Tue, 5 Apr 2016 14:24:41 +0900 (JST))

> Date: Tue, 5 Apr 2016 14:24:41 +0900 (JST)
> From: Tino Calancha <f92capac@gmail.com>
> cc: Tino Calancha <f92capac@gmail.com>, 23206@debbugs.gnu.org
> 
> >This means the fix should only affect systems with a Posix
> >shell.
> >The stock MS-Windows shells don't have a 'wait' command (and
> >don't need this fix in the first place, as the problem doesn't exist
> >on MS-Windows, AFAICS).
> I see.  Thank you.
> I rewrote the patch so that it adds 'wait' when 'system-type' is
> not in '(ms-dos windows-nt).

Thanks.

I have one more nit:

> * lisp/dired-aux.el (dired-shell-stuff-it):
> Drop all trailing ';' and '&' in command;
> change indentation with \t to ?\s;

These are unrelated changes, so please don't mix them with the changes
that really fix the problem at hand.  In particular, removing all the
trailing ';' and '&' characters might cause bugs, because the code you
are modifying doesn't really understand what the shell command is
about, so it might inadvertently delete characters that are there for
a reason.  It is up to the user to type a correct command, and Emacs
shouldn't try second-guessing those commands.  So let's only remove a
single instance of these characters at the end, as the original code
did.

Thanks.





  reply	other threads:[~2016-04-05 14:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-03 13:02 bug#23206: 25.0.92; dired-shell-stuff-it: wait until all parallel jobs finish Tino Calancha
2016-04-03 15:03 ` Eli Zaretskii
2016-04-03 16:38   ` Tino Calancha
2016-04-04  6:20     ` Tino Calancha
2016-04-04 17:25     ` Eli Zaretskii
2016-04-05  5:24       ` Tino Calancha
2016-04-05 14:59         ` Eli Zaretskii [this message]
2016-04-05 15:58           ` Tino Calancha
2016-04-08 14:06             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83vb3wm791.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=23206@debbugs.gnu.org \
    --cc=f92capac@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.