From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: PIXEL_ALREADY_TYPEDEFED Date: Tue, 14 Jun 2016 18:11:00 +0300 Message-ID: <83vb1bergb.fsf@gnu.org> References: <68d7f532-65df-5d3d-a650-5f1614fa3a6b@cornell.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1465920005 25138 80.91.229.3 (14 Jun 2016 16:00:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 14 Jun 2016 16:00:05 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ken Brown Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 14 18:00:05 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bCqkz-0005f2-Af for ged-emacs-devel@m.gmane.org; Tue, 14 Jun 2016 18:00:01 +0200 Original-Received: from localhost ([::1]:36338 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCqky-0006IJ-AJ for ged-emacs-devel@m.gmane.org; Tue, 14 Jun 2016 12:00:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCpyo-0000Do-DI for emacs-devel@gnu.org; Tue, 14 Jun 2016 11:10:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCpyi-0007Pu-PZ for emacs-devel@gnu.org; Tue, 14 Jun 2016 11:10:13 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCpyi-0007OS-MF; Tue, 14 Jun 2016 11:10:08 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4555 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bCpyg-0005bJ-Po; Tue, 14 Jun 2016 11:10:07 -0400 In-reply-to: <68d7f532-65df-5d3d-a650-5f1614fa3a6b@cornell.edu> (message from Ken Brown on Tue, 14 Jun 2016 10:09:27 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204359 Archived-At: > Cc: Emacs > From: Ken Brown > Date: Tue, 14 Jun 2016 10:09:27 -0400 > > To get rid of an "unused macro" warning in the Cygwin-w32 build, I want > to remove the definition of PIXEL_ALREADY_TYPEDEFED from image.c. (It's > defined in simx.h, which is included by xpm.h, on Cygwin.) In the > course of doing this, I decided to do some cleanup that you suggested in > the discussion of bug#18302. See the attached patch, not yet installed. Fine with me, it's a Cygwin-only change. > Question: Should PIXEL_ALREADY_TYPEDEFED be removed unconditionally, or > is it needed in the MinGW build? Deleting it causes no trouble with the version of libXpm headers I have here (3.5.11), but I hope it won't give trouble to other versions. Let's remove it and see if someone hollers. Thanks.