From: Eli Zaretskii <eliz@gnu.org>
To: Ken Brown <kbrown@cornell.edu>
Cc: emacs-devel@gnu.org
Subject: Re: PIXEL_ALREADY_TYPEDEFED
Date: Tue, 14 Jun 2016 18:11:00 +0300 [thread overview]
Message-ID: <83vb1bergb.fsf@gnu.org> (raw)
In-Reply-To: <68d7f532-65df-5d3d-a650-5f1614fa3a6b@cornell.edu> (message from Ken Brown on Tue, 14 Jun 2016 10:09:27 -0400)
> Cc: Emacs <emacs-devel@gnu.org>
> From: Ken Brown <kbrown@cornell.edu>
> Date: Tue, 14 Jun 2016 10:09:27 -0400
>
> To get rid of an "unused macro" warning in the Cygwin-w32 build, I want
> to remove the definition of PIXEL_ALREADY_TYPEDEFED from image.c. (It's
> defined in simx.h, which is included by xpm.h, on Cygwin.) In the
> course of doing this, I decided to do some cleanup that you suggested in
> the discussion of bug#18302. See the attached patch, not yet installed.
Fine with me, it's a Cygwin-only change.
> Question: Should PIXEL_ALREADY_TYPEDEFED be removed unconditionally, or
> is it needed in the MinGW build?
Deleting it causes no trouble with the version of libXpm headers I
have here (3.5.11), but I hope it won't give trouble to other
versions. Let's remove it and see if someone hollers.
Thanks.
next prev parent reply other threads:[~2016-06-14 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 14:09 PIXEL_ALREADY_TYPEDEFED Ken Brown
2016-06-14 15:11 ` Eli Zaretskii [this message]
2016-06-14 17:50 ` PIXEL_ALREADY_TYPEDEFED Ken Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vb1bergb.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kbrown@cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.