all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Your changes in ibuffer.el and ibuf-ext.el
@ 2016-07-08  9:53 Eli Zaretskii
  2016-07-11  2:44 ` Tino Calancha
  0 siblings, 1 reply; 2+ messages in thread
From: Eli Zaretskii @ 2016-07-08  9:53 UTC (permalink / raw)
  To: Tino Calancha; +Cc: emacs-devel

Those changes seem to trigger compilation warnings:

    ELC      ibuffer.elc

  In toplevel form:
  ibuffer.el:1333:1:Warning: argument `_mark' not left unused

  In toplevel form:
  ibuf-ext.el:1504:1:Warning: Unused lexical variable `char'
  ibuf-ext.el:1504:1:Warning: variable `_buffer' not left unused

Those sound like actual problems that need to be fixed.  (Did you know
about the special meaning of the leading underscore in argument
names?)

Thanks.



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Your changes in ibuffer.el and ibuf-ext.el
  2016-07-08  9:53 Your changes in ibuffer.el and ibuf-ext.el Eli Zaretskii
@ 2016-07-11  2:44 ` Tino Calancha
  0 siblings, 0 replies; 2+ messages in thread
From: Tino Calancha @ 2016-07-11  2:44 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel, Tino Calancha



On Fri, 8 Jul 2016, Eli Zaretskii wrote:

> Those changes seem to trigger compilation warnings:
>
>    ELC      ibuffer.elc
>
>  In toplevel form:
>  ibuffer.el:1333:1:Warning: argument `_mark' not left unused
>
>  In toplevel form:
>  ibuf-ext.el:1504:1:Warning: Unused lexical variable `char'
>  ibuf-ext.el:1504:1:Warning: variable `_buffer' not left unused
>
> Those sound like actual problems that need to be fixed.  (Did you know
> about the special meaning of the leading underscore in argument
> names?)
I just fixed it.
That reminds me to always compile and check the *Compile-Log* after
adding changes.

Thank you very much.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-07-11  2:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-08  9:53 Your changes in ibuffer.el and ibuf-ext.el Eli Zaretskii
2016-07-11  2:44 ` Tino Calancha

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.