From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24041: 25.1.50; xwidget + -nw mode gives segfault Date: Mon, 22 Aug 2016 21:49:59 +0300 Message-ID: <83vaysfxk8.fsf@gnu.org> References: <8760qwtxld.fsf@cochranmail.com> <83oa4ndhfw.fsf@gnu.org> <87lgzrm8ft.fsf@cochranmail.com> <8360qudeuj.fsf@gnu.org> <878tvpa6w6.fsf@cochranmail.com> <83k2f8c1cd.fsf@gnu.org> <87k2f87j2g.fsf@cochranmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1471891882 26830 195.159.176.226 (22 Aug 2016 18:51:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 22 Aug 2016 18:51:22 +0000 (UTC) Cc: shanemhansen@gmail.com, 24041@debbugs.gnu.org To: Robert Cochran , joakim@verona.se Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 22 20:51:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbuJY-0006Wq-Sx for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Aug 2016 20:51:17 +0200 Original-Received: from localhost ([::1]:42735 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbuJX-0005jI-8X for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Aug 2016 14:51:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbuJO-0005hM-J3 for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2016 14:51:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bbuJK-0005Sg-CE for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2016 14:51:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbuJK-0005Sc-98 for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2016 14:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bbuJK-0007sp-2O for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2016 14:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Aug 2016 18:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24041 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24041-submit@debbugs.gnu.org id=B24041.147189181030235 (code B ref 24041); Mon, 22 Aug 2016 18:51:02 +0000 Original-Received: (at 24041) by debbugs.gnu.org; 22 Aug 2016 18:50:10 +0000 Original-Received: from localhost ([127.0.0.1]:37172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbuIU-0007ra-B9 for submit@debbugs.gnu.org; Mon, 22 Aug 2016 14:50:10 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbuIS-0007rO-Qj for 24041@debbugs.gnu.org; Mon, 22 Aug 2016 14:50:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bbuII-00059q-Ed for 24041@debbugs.gnu.org; Mon, 22 Aug 2016 14:50:03 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbuII-00059I-Aw; Mon, 22 Aug 2016 14:49:58 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3331 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bbuIF-0001jP-HU; Mon, 22 Aug 2016 14:49:56 -0400 In-reply-to: <87k2f87j2g.fsf@cochranmail.com> (message from Robert Cochran on Mon, 22 Aug 2016 11:30:15 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122519 Archived-At: > From: Robert Cochran > Cc: Robert Cochran , shanemhansen@gmail.com, 24041@debbugs.gnu.org > Date: Mon, 22 Aug 2016 11:30:15 -0700 > > > My only comment is that you could call check_x_display_info with Qnil > > as its argument. > > I did think about that. But then it arguably does the wrong thing: > `check_x_display_info` with `Qnil` only signals an error when there have > never been X windows, eg, opening and closing an X window satisfies the > check from then on. It no longer crashes in that instance, but I > personally don't think that's the right behavior; if my starting frame > isn't capable of displaying an xwidget, say so! Hence checking with the > current frame. Joakim, is it certain that the xwidget will always be shown in the frame that is the selected one at the time make-xwidget is called? > Thanks for your reassurance! My one gripe about this patch is that I > didn't figure out how to kill the buffer after xwidget creation failure > (leaving it seems rather ugly IMO), but I just now realized what I can > do. As long as it's not considered wrong to kill a mode's buffer on > error, would you also consider this patch to go along with it? I'm not sure if this is TRT. I'd rather erase-buffer at the beginning of xwidget-webkit-new-session, and leave the buffer alone if we signal an error. The buffer might have contents that the user will hate losing, for diagnostic purposes if nothing else. Joakim, WDYT?