From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 24549-done@debbugs.gnu.org
Subject: bug#24549: 25.1; Customizing group `text'
Date: Sat, 08 Oct 2016 16:40:49 +0300 [thread overview]
Message-ID: <83vax3gdr2.fsf@gnu.org> (raw)
In-Reply-To: <2d7216a4-60c9-40fb-95e4-91894284fbee@default> (message from Drew Adams on Tue, 27 Sep 2016 09:58:29 -0700 (PDT))
> Date: Tue, 27 Sep 2016 09:58:29 -0700 (PDT)
> From: Drew Adams <drew.adams@oracle.com>
> Cc: 24549@debbugs.gnu.org
>
> > > IOW, we can (1) make a group `text' that behaves essentially
> > > like `wp' and (2) let users know that `wp' is considered
> > > deprecated.
> >
> > If this works, it is probably better, yes.
>
> IOW, something like the code below.
Thanks, done on the master branch.
> Question 1: Why is group `outlines' declared in both
> cus-edit.el and outline.el? And in outline.el it has a
> prefix declared, but not in cus-edit.el. Group `outlines'
> is not _used_ in cus-edit.el, AFAICT. What would happen
> if we removed group `outlines' from cus-edit.el?
> (This question has nothing to do with this bug report.
> Just happened to notice the duplication.)
This duplication is an oversight from when outline.el was converted to
use Custom. I fixed this now.
> Question 2: Should group `text' inherit directly from group
> `emacs'? Should it also inherit from group `wp'?
I left it inherit from both. It cannot do any harm, I think.
> I think the answer to both of these is yes. WDYT?
>
> Question 3: Should group `wp' still be inherited from, by a
> group that now inherits from `text'? E.g., should group
> `tildify' inherit from both `wp' as well as from `text'?
>
> I don't think so. If group `text' itself inherits from `wp'
> then I don't think there is any reason that we need to have
> other groups still inherit directly from `wp' (as well as
> from `text'). WDYT?
I agree.
I think this bug is now done.
next prev parent reply other threads:[~2016-10-08 13:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<8aaf30c2-ceb2-4803-9e2e-cd10ad8a3802@default>
[not found] ` <<837f9xct9z.fsf@gnu.org>
[not found] ` <<9eab3611-2ed6-422b-93bc-4270ef1b6082@default>
[not found] ` <<83twd1bcx6.fsf@gnu.org>
2016-09-27 16:58 ` bug#24549: 25.1; Customizing group `text' Drew Adams
2016-10-08 13:40 ` Eli Zaretskii [this message]
2016-09-26 20:46 Drew Adams
2016-09-26 20:54 ` Drew Adams
2016-09-27 14:27 ` Eli Zaretskii
2016-09-27 14:49 ` Drew Adams
2016-09-27 15:05 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vax3gdr2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=24549-done@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.