From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el Date: Fri, 02 Dec 2016 16:24:26 +0200 Message-ID: <83vav2mmsl.fsf@gnu.org> References: <6d0c8c2e-8428-2fdb-0d6e-899f7b9d7ffd@nifty.com> <8053af81-80e1-a24a-f649-8ffc86963ed5@nifty.com> <0cc7fab4-9a2c-6a8d-def7-36bd50317ca3@yandex.ru> <7f9a799f-de88-fd78-0cdc-dac0928f1503@nifty.com> <308bb78f-8be3-092d-d877-e129d340242b@nifty.com> <4dc615e7-ec73-60a5-426e-0d6986f15d76@yandex.ru> <0cb406fb-ffc4-a4ad-557a-2cacc99b8e75@nifty.com> <86ccb4af-5719-c017-26bb-fc06b4c904d2@yandex.ru> <83r35uxkr5.fsf@gnu.org> <4e12d4ad-cd6b-3087-5d7c-449d4c1886e2@yandex.ru> <83lgw1q9uu.fsf@gnu.org> <83eg1tq8is.fsf@gnu.org> <787e5206-53e0-752f-a339-4608d2f7ad39@yandex.ru> <837f7lq6lg.fsf@gnu.org> <83bmwvpo0o.fsf@gnu.org> <04e2da4e-1fa3-4483-459c-32f272378486@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1480688760 6600 195.159.176.226 (2 Dec 2016 14:26:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 2 Dec 2016 14:26:00 +0000 (UTC) Cc: p.stephani2@gmail.com, emacs-devel@gnu.org, larsi@gnus.org, kentaro.nakazawa@nifty.com To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 02 15:25:52 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cComd-0000PV-M7 for ged-emacs-devel@m.gmane.org; Fri, 02 Dec 2016 15:25:51 +0100 Original-Received: from localhost ([::1]:34781 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cComg-00078J-0S for ged-emacs-devel@m.gmane.org; Fri, 02 Dec 2016 09:25:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cColF-0006gp-Tg for emacs-devel@gnu.org; Fri, 02 Dec 2016 09:24:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cColB-0007E0-HQ for emacs-devel@gnu.org; Fri, 02 Dec 2016 09:24:25 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cColB-0007Dk-D6; Fri, 02 Dec 2016 09:24:21 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1680 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cColA-0002yX-7p; Fri, 02 Dec 2016 09:24:21 -0500 In-reply-to: <04e2da4e-1fa3-4483-459c-32f272378486@yandex.ru> (message from Dmitry Gutov on Fri, 2 Dec 2016 15:18:48 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209918 Archived-At: > Cc: p.stephani2@gmail.com, larsi@gnus.org, kentaro.nakazawa@nifty.com, > emacs-devel@gnu.org > From: Dmitry Gutov > Date: Fri, 2 Dec 2016 15:18:48 +0200 > > > it is okay to silently DTRT for > > that class only, in some central place that serves the class. > > Those central places are coding.c and url/url-*.el. That's not what I meant (and coding.c is definitely not the place), but let's leave this alone. > diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el > index e0e080e..affd5c2 100644 > --- a/lisp/url/url-http.el > +++ b/lisp/url/url-http.el > @@ -358,9 +358,8 @@ url-http-create-request > ;; Any data > url-http-data)) > ;; Bug#23750 > - (unless (= (string-bytes request) > - (length request)) > - (error "Multibyte text in HTTP request: %s" request)) > + (when (mutibyte-string-p request) > + (error "Multibyte text in HTTP request: %s, please translate any > multibyte components to unibyte using `encode-coding-string'" request)) > (url-http-debug "Request is: \n%s" request) > request)) This will also reject pure-ASCII strings that just happen to be multibyte, although there will be no problem with such an HTTP request. Do we really want to disallow that use case?