From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: 64-bit build on Windows Date: Sun, 22 Jan 2017 18:50:59 +0200 Message-ID: <83vat73uoc.fsf@gnu.org> References: <874m0tc0gn.fsf@russet.org.uk> <87efzxn6or.fsf@wanadoo.es> <83y3y5681f.fsf@gnu.org> <83h94s5kzi.fsf@gnu.org> <838tq45gsk.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1485103932 2029 195.159.176.226 (22 Jan 2017 16:52:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 22 Jan 2017 16:52:12 +0000 (UTC) Cc: ofv@wanadoo.es, lekktu@gmail.com, emacs-devel@gnu.org To: Fabrice Popineau Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 22 17:52:04 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cVLMj-0006Ue-JJ for ged-emacs-devel@m.gmane.org; Sun, 22 Jan 2017 17:51:41 +0100 Original-Received: from localhost ([::1]:36955 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVLMo-000764-Ot for ged-emacs-devel@m.gmane.org; Sun, 22 Jan 2017 11:51:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVLME-00075o-Il for emacs-devel@gnu.org; Sun, 22 Jan 2017 11:51:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cVLM9-0007Cf-Vg for emacs-devel@gnu.org; Sun, 22 Jan 2017 11:51:10 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cVLM9-0007Cb-SJ; Sun, 22 Jan 2017 11:51:05 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3803 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cVLM8-0006U2-Bd; Sun, 22 Jan 2017 11:51:05 -0500 In-reply-to: (message from Fabrice Popineau on Sat, 21 Jan 2017 21:40:44 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211534 Archived-At: > From: Fabrice Popineau > Date: Sat, 21 Jan 2017 21:40:44 +0100 > Cc: Juanma Barranquero , Óscar Fuentes , > Emacs developers > > Please describe how this would work, without using > dynamic-library-alist. > > But I never said that it would work without using dynamic-library-alist ? Then it seems we are in violent agreement about this. This sub-thread started when I said ImageMagick was not supported on Windows because it could only be linked in statically. You disagreed with that, but now it looks like you actually agree, and posted a patch to add the missing stuff. > + '(magickwand "libMagickWand-7.Q16HDRI-0.dll" "libMagickWand-7.Q16-0.dll") > + '(magickcore "libMagickCore-7.Q16HDRI-0.dll" "libMagickCore-7.Q16-0.dll") Does this mean we will only support ImageMagick 7.x and later on Windows? If so, the configure-time test should be changed, since it currently allows 6.x, I think. > +static bool > +init_imagemagick_functions (void) > +{ > + HMODULE magickwand, magickcore; > + > + if (!(magickcore = w32_delayed_load (Qmagickcore)) > + || !(magickwand = w32_delayed_load (Qmagickwand))) > + return 0; Are these 2 DLLs completely independent? Or will loading one of them automatically load the other, due to dependencies? > @@ -8406,7 +8776,7 @@ imagemagick_compute_animated_image (MagickWand *super_wand, int ino) > PixelWand **source, **dest; > size_t source_width, source_height; > ssize_t source_left, source_top; > - MagickPixelPacket pixel; > + PixelInfo pixel; What is this about? > +#if defined HAVE_NTGUI && !defined CYGWIN A.k.a. "#ifdef WINDOWSNT". Thanks.