Re: Advice needed on modeline customization hack...

[Eli Zaretskii <eliz@gnu.org>]

> Date: Mon, 17 Apr 2017 14:07:40 -0400
> From: "Perry E. Metzger" <perry@piermont.com>
> Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org
> 
> On Mon, 17 Apr 2017 18:34:25 +0300 Eli Zaretskii <eliz@gnu.org> wrote:
> > The entry should be preceded by "+++", to indicate that the manuals
> > were updated.
> 
> I vaguely remember that convention but I couldn't find it documented

It's documented at the beginning of NEWS.  And you can see examples of
that in other NEWS entries.

> +(defcustom column-number-indicator-zero-based t
> +  "When set to true, Column Number mode displays columns starting
> +from zero at the left margin of the window. Otherwise, displayed
> +column numbers start from one."

The first line of a doc string should be a complete sentence.
Something like

    When non-nil, mode line displays column numbers zero-based.

  This variable has effect only when Column Number mode is turned on,
  which displays column numbers in the mode line.
  If the value is non-nil, the displayed column numbers start from
  zero, otherwise they start from one.

Also, 2 spaces between sentences...

Don't worry about these nits, they can be fixed when pushing.

Let's wait for a few days to give others a chance to comment.

Thanks.