From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Trimming strings, /emacs/lisp/emacs-lisp/subr-x.el modification Date: Mon, 08 May 2017 17:28:36 +0300 Message-ID: <83vapbctij.fsf@gnu.org> References: <87vapij1l7.fsf@holos> <6870A2B6-F685-4955-9C0A-256601DB47BC@gmail.com> <51D5E92C-F125-4ADE-8C55-E3513C00ECDC@gmail.com> <8F6958D6-3E13-4C31-B1F8-AF10A8FC8FC6@gmail.com> <838tmafigi.fsf@gnu.org> <7C79DA34-96F2-4D9F-9E9C-01574AE00F12@gmail.com> <8360hefepp.fsf@gnu.org> <0E129E02-FA64-4664-825B-8854A66CA9C6@gmail.com> <3D0BA0E6-02E2-4E90-8A59-121065547E1C@gmail.com> <87ziepho0q.fsf@gnu.org> <83vapderm3.fsf@gnu.org> <87vapdhi9j.fsf@gnu.org> <83tw4xeorf.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1494253809 18481 195.159.176.226 (8 May 2017 14:30:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 8 May 2017 14:30:09 +0000 (UTC) Cc: mvoteiza@udel.edu, emacs-devel@gnu.org, bojohan@gnu.org, tino.calancha@gmail.com To: Jean-Christophe Helary Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 08 16:30:05 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d7jfp-0004jA-Ak for ged-emacs-devel@m.gmane.org; Mon, 08 May 2017 16:30:05 +0200 Original-Received: from localhost ([::1]:59768 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7jfu-0004Xd-Tf for ged-emacs-devel@m.gmane.org; Mon, 08 May 2017 10:30:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7jev-0004Vx-BL for emacs-devel@gnu.org; Mon, 08 May 2017 10:29:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7jer-0008HP-9p for emacs-devel@gnu.org; Mon, 08 May 2017 10:29:09 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52606) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7jer-0008HL-6T; Mon, 08 May 2017 10:29:05 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1448 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d7jep-0002mG-Ie; Mon, 08 May 2017 10:29:04 -0400 In-reply-to: (message from Jean-Christophe Helary on Mon, 8 May 2017 11:40:33 +0900) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214692 Archived-At: > From: Jean-Christophe Helary > Date: Mon, 8 May 2017 11:40:33 +0900 > Cc: Johan Bockgård , > mvoteiza@udel.edu, > tino.calancha@gmail.com, > emacs-devel@gnu.org > > >>>> I think regexp should be surrounded by a grouping construct, like: > >>>> > >>>> (concat "\\`\\(?:" (or regexp "[ \t\n\r]+") "\\)") > >>>> > >>>> And similarly for string-trim-right. > >>> > >>> Rationale? > >> > >> regexp can contain \| > > > > Shouldn't such a regexp be surrounded by "\\(..\\)"? > > So you both agree that the regexp should be surrounded by a grouping construct but you're arguing whether it should be a "normal" grouping or a shy grouping ? No, the issue is whether the function should enclose the argument in a grouping constructs of any kind, or should this be the caller's responsibility when the regexp includes \|. > > I'm _asking_ whether it should be the caller's duty. > > How does that relate to the "shy" vs "non-shy" thing above? It doesn't.