From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23568: 25.0.94; Mode line menus appear incorrectly in some monitor configurations Date: Sat, 03 Jun 2017 09:32:12 +0300 Message-ID: <83vaodbmz7.fsf@gnu.org> References: <871t50xvm6.fsf@gmail.com> <87y3thjw4i.fsf@gmail.com> <87vaoh1os3.fsf@gmail.com> <592E8C4A.7000104@gmx.at> <87vaoglo72.fsf@gmail.com> <592FA8A5.8060100@gmx.at> <874lvzzbwf.fsf@gmail.com> <87zidrxwhn.fsf@gmail.com> <5931014B.20700@gmx.at> <8737bi97s9.fsf@gmail.com> <59312948.5000907@gmx.at> <87shjhopqs.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1496471596 16832 195.159.176.226 (3 Jun 2017 06:33:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 3 Jun 2017 06:33:16 +0000 (UTC) Cc: 23568@debbugs.gnu.org To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 03 08:33:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dH2cU-0003rB-JJ for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Jun 2017 08:33:06 +0200 Original-Received: from localhost ([::1]:52699 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dH2cY-0004GN-F5 for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 Jun 2017 02:33:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dH2cT-0004GH-BC for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2017 02:33:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dH2cQ-0005CF-8D for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2017 02:33:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49663) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dH2cQ-0005Bx-5n for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2017 02:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dH2cQ-0002EF-0I for bug-gnu-emacs@gnu.org; Sat, 03 Jun 2017 02:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Jun 2017 06:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23568 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23568-submit@debbugs.gnu.org id=B23568.14964715608540 (code B ref 23568); Sat, 03 Jun 2017 06:33:01 +0000 Original-Received: (at 23568) by debbugs.gnu.org; 3 Jun 2017 06:32:40 +0000 Original-Received: from localhost ([127.0.0.1]:52340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dH2c4-0002Df-5W for submit@debbugs.gnu.org; Sat, 03 Jun 2017 02:32:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dH2c2-0002DS-8B for 23568@debbugs.gnu.org; Sat, 03 Jun 2017 02:32:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dH2bt-0004Li-Sh for 23568@debbugs.gnu.org; Sat, 03 Jun 2017 02:32:33 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dH2bt-0004LO-QD; Sat, 03 Jun 2017 02:32:29 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4447 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dH2br-0008O2-3X; Sat, 03 Jun 2017 02:32:27 -0400 In-reply-to: <87shjhopqs.fsf@gmail.com> (message from Alex on Fri, 02 Jun 2017 18:54:03 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133208 Archived-At: > From: Alex > Date: Fri, 02 Jun 2017 18:54:03 -0600 > Cc: 23568@debbugs.gnu.org > > I fixed up the docstrings to match display-monitor-attributes-list. Thanks, a few comments below. > Don't you want to throw an error when x and y are used, but are not > integers? If this is supposed to be used as part of mode-line display, then no. Signaling errors in the middle of redisplay is generally a bad idea, because they cause another redisplay cycle, which again signals an error, and Emacs just freezes. > +(defun display-monitor-attribute (attribute &optional display x y) > + "Return the value of the ATTRIBUTE of the current monitor. The doc string should say something about what "the current monitor" means, or have a link to where that is explained. > +DISPLAY can be a display name, a terminal name, or a frame. "Terminal name" or "terminal object"? > +(defun display-monitor-geometry (&optional display x y) > + "Return the geometry of the current monitor. > +DISPLAY can be a display name, a terminal name, or a frame. Same here, on both counts. > diff --git a/src/xmenu.c b/src/xmenu.c > index 2805249164..04d5bde2ba 100644 > --- a/src/xmenu.c > +++ b/src/xmenu.c Why is this in xmenu.c? Is the problem unique to X window system?