From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27668: 26.0.50; Crash with display-line-numbers t Date: Fri, 14 Jul 2017 12:51:06 +0300 Message-ID: <83vamvfit1.fsf@gnu.org> References: <87k23d7ovv.fsf@gmail.com> <83inixiv0m.fsf@gnu.org> <877ezd7luq.fsf@gmail.com> <83bmopitky.fsf@gnu.org> <87vamx65x0.fsf@gmail.com> <837ezdiq3z.fsf@gnu.org> <871spl5x5h.fsf@gmail.com> <834luhiinr.fsf@gnu.org> <8760ewviyt.fsf@gmail.com> <83pod4gv0i.fsf@gnu.org> <87r2xkl246.fsf@gmail.com> <83mv88gqzi.fsf@gnu.org> <87mv88kxps.fsf@gmail.com> <83eftkgn06.fsf@gnu.org> <87iniwku3y.fsf@gmail.com> <83zic7fnrv.fsf@gnu.org> <87d1931jiy.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1500026435 23204 195.159.176.226 (14 Jul 2017 10:00:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 14 Jul 2017 10:00:35 +0000 (UTC) To: 27668@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 14 12:00:31 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVxOg-0005ma-Ap for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Jul 2017 12:00:30 +0200 Original-Received: from localhost ([::1]:36646 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVxOl-0007MU-Rn for geb-bug-gnu-emacs@m.gmane.org; Fri, 14 Jul 2017 06:00:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVxGX-0008A1-AU for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2017 05:52:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVxGU-0005jz-8P for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2017 05:52:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35089) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dVxGU-0005jv-5E for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2017 05:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dVxGT-0001el-Vv for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2017 05:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jul 2017 09:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27668 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15000258796311 (code B ref -1); Fri, 14 Jul 2017 09:52:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Jul 2017 09:51:19 +0000 Original-Received: from localhost ([127.0.0.1]:37766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVxFn-0001dj-1A for submit@debbugs.gnu.org; Fri, 14 Jul 2017 05:51:19 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVxFm-0001dW-BB for submit@debbugs.gnu.org; Fri, 14 Jul 2017 05:51:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVxFg-0005O0-AT for submit@debbugs.gnu.org; Fri, 14 Jul 2017 05:51:13 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:47885) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dVxFg-0005Nt-70 for submit@debbugs.gnu.org; Fri, 14 Jul 2017 05:51:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVxFe-0007YP-TA for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2017 05:51:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVxFZ-0005Hk-4P for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2017 05:51:10 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVxFZ-0005Hd-18 for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2017 05:51:05 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4274 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dVxFY-0006qc-DW for bug-gnu-emacs@gnu.org; Fri, 14 Jul 2017 05:51:04 -0400 In-reply-to: <87d1931jiy.fsf@gmail.com> (message from Robert Pluim on Fri, 14 Jul 2017 10:59:17 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134541 Archived-At: > From: Robert Pluim > Date: Fri, 14 Jul 2017 10:59:17 +0200 > > xdisp.c:21012: Emacs fatal error: assertion failed: it->glyph_row == NULL || it->glyph_row->used[TEXT_AREA] == 0 > > Thread 1 "emacs" hit Breakpoint 1, terminate_due_to_signal (sig=sig@entry=6, > backtrace_limit=backtrace_limit@entry=2147483647) at emacs.c:363 > 363 { > (gdb) bt > #0 terminate_due_to_signal (sig=sig@entry=6, backtrace_limit=backtrace_limit@entry=2147483647) at emacs.c:363 > #1 0x00000000005a4ed4 in die (msg=msg@entry=0x67aec0 "it->glyph_row == NULL || it->glyph_row->used[TEXT_AREA] == 0", > file=file@entry=0x678e68 "xdisp.c", line=line@entry=21012) at alloc.c:7348 > #2 0x000000000045befb in maybe_produce_line_number (it=it@entry=0x7fffffff8130) at xdisp.c:21012 > #3 0x0000000000465335 in display_line (it=it@entry=0x7fffffff8130, cursor_vpos=cursor_vpos@entry=9) at xdisp.c:21227 > #4 0x000000000046728d in try_window (window=..., window@entry=XIL(0x146e6c5), pos=..., flags=flags@entry=1) > at xdisp.c:17544 > #5 0x000000000047f8fb in redisplay_window (window=XIL(0x146e6c5), just_this_one_p=just_this_one_p@entry=false) > at xdisp.c:16991 In this frame #5, in redisplay_window, which of the conditions in the following 'if' clause are true? /* Try to redisplay starting at same place as before. If point has not moved off frame, accept the results. */ if (!current_matrix_up_to_date_p /* Don't use try_window_reusing_current_matrix in this case because a window scroll function can have changed the buffer. */ || !NILP (Vwindow_scroll_functions) || MINI_WINDOW_P (w) || !(used_current_matrix_p = try_window_reusing_current_matrix (w))) { IF_DEBUG (debug_method_add (w, "1")); if (try_window (window, startp, TRY_WINDOW_CHECK_MARGINS) < 0) It cannot be MINI_WINDOW_P, so it's either current_matrix_up_to_date_p is false, or your window-scroll-functions is non-nil, or we called try_window_reusing_current_matrix. In the latter case, I'd expect my recent change to fix the problem, so I guess that function wasn't called, and some other condition caused us to call try_window. Or maybe I'm missing something here. > I was looking at a commit in Magit, and had just hit enter in a diff > hunk to view the source file containing the change, so it's happening > when we switch from non-line-number to line-number mode. How do you "switch from non-line-number to line-number mode"? I tried several ways I could think about, but couldn't reproduce the issue. I wonder what's different in your case that you hit this problem so frequently. Did the previous times also happened when switching from a Magit buffer to a buffer under display-line-numbers?