From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 29334@debbugs.gnu.org, vianchielfaura@gmail.com
Subject: bug#29334: 25.3; compiled commands don't respect special interactive expressions
Date: Fri, 24 Nov 2017 09:58:29 +0200 [thread overview]
Message-ID: <83vai09kgq.fsf@gnu.org> (raw)
In-Reply-To: <87efooz7z8.fsf@users.sourceforge.net> (message from Noam Postavsky on Thu, 23 Nov 2017 22:11:23 -0500)
> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Thu, 23 Nov 2017 22:11:23 -0500
> Cc: 29334@debbugs.gnu.org, Allen Li <vianchielfaura@gmail.com>
>
> > Bisected to a46481370, our old friend "Use lexical-binding".
>
> How about this:
>
> >From a8b43e98c592c84957ea304a0dc2d6423af9c5c5 Mon Sep 17 00:00:00 2001
> From: Noam Postavsky <npostavs@gmail.com>
> Date: Thu, 23 Nov 2017 21:57:09 -0500
> Subject: [PATCH] Fix command repetition with lexical-binding (Bug#29334)
>
> `call-interactively' relies on analyzing the source of `interactive'
> forms in order to preserve arguments like (region-end) in the command
> history, rather than just storing the resulting position. However,
> the byte-compiler does not preserve the source of the interactive form
> when lexical-binding is in effect, because `call-interactively' would
> evaluate the form with dynamic binding in that case.
>
> To fix this, change `call-interactively' so that it checks compiled
> functions for lexical-binding as well. Then the byte-compiler can
> preserve the source of interactive forms regardless of the value of
> lexical-binding.
Thanks. If no objections are voiced to this approach, please push it
to the master branch. I think this is too radical for the release
branch.
P.S. Should this change be reflected in the ELisp manual somehow?
next prev parent reply other threads:[~2017-11-24 7:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 6:17 bug#29334: 25.3; compiled commands don't respect special interactive expressions Allen Li
2017-11-17 14:55 ` Drew Adams
2018-01-04 5:25 ` Stefan Monnier
2017-11-21 19:45 ` Glenn Morris
2017-11-24 3:11 ` Noam Postavsky
2017-11-24 7:58 ` Eli Zaretskii [this message]
2017-11-24 12:17 ` Noam Postavsky
2018-01-04 2:56 ` Noam Postavsky
2018-01-07 2:55 ` Noam Postavsky
2022-02-10 7:56 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vai09kgq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=29334@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
--cc=vianchielfaura@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.