From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29478: [Patch] bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event Date: Sat, 27 Jan 2018 09:59:15 +0200 Message-ID: <83vafnka0c.fsf@gnu.org> References: <20171128221036.GC14868@ACM> <83o9ni3l3i.fsf@gnu.org> <83bmji2xye.fsf@gnu.org> <83tvwzubez.fsf@gnu.org> <20171222220549.GC8072@ACM> <833741lr0t.fsf@gnu.org> <20171223111726.GA6618@ACM> <20171223210407.GC6618@ACM> <831sjcfq1v.fsf@gnu.org> <83zi5q997a.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1517039922 28383 195.159.176.226 (27 Jan 2018 07:58:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 27 Jan 2018 07:58:42 +0000 (UTC) Cc: acm@muc.de, 29478@debbugs.gnu.org, npostavs@users.sourceforge.net To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 27 08:58:37 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efLNN-0005bn-SP for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jan 2018 08:58:13 +0100 Original-Received: from localhost ([::1]:33068 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efLPM-0007GB-QH for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jan 2018 03:00:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efLPE-0007FY-8N for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2018 03:00:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1efLPA-0005rw-B4 for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2018 03:00:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36404) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1efLPA-0005rj-7E for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2018 03:00:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1efLP8-0006wj-KP for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2018 03:00:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jan 2018 08:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29478 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 29478-submit@debbugs.gnu.org id=B29478.151703998326642 (code B ref 29478); Sat, 27 Jan 2018 08:00:02 +0000 Original-Received: (at 29478) by debbugs.gnu.org; 27 Jan 2018 07:59:43 +0000 Original-Received: from localhost ([127.0.0.1]:44301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efLOo-0006vd-Cp for submit@debbugs.gnu.org; Sat, 27 Jan 2018 02:59:42 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:39278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efLOm-0006vR-4u for 29478@debbugs.gnu.org; Sat, 27 Jan 2018 02:59:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1efLOc-0005Mv-LX for 29478@debbugs.gnu.org; Sat, 27 Jan 2018 02:59:34 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50251) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efLOP-0005D5-Da; Sat, 27 Jan 2018 02:59:17 -0500 Original-Received: from [176.228.60.248] (port=2297 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1efLOO-0005ub-3J; Sat, 27 Jan 2018 02:59:17 -0500 In-reply-to: (message from Stefan Monnier on Fri, 26 Jan 2018 17:00:15 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142568 Archived-At: > From: Stefan Monnier > Cc: acm@muc.de, 29478@debbugs.gnu.org, npostavs@users.sourceforge.net > Date: Fri, 26 Jan 2018 17:00:15 -0500 > > > at that spot runs the command mouse-appearance-menu > > at that spot is undefined > > > > I'd expect the second line not to appear. > > About that, I wrote: > > OTOH, for text-terminals, we add a "(translated from )" > and we could do the same here (that's what my patch originally did, by > the way, and that's what I've been using all these years since I think > it's very valuable information), which would say: > > (translated from ) > at that spot is undefined > > but I misremembered, the above also appears in vanilla Emacs. Regarding > your example: > > at that spot runs the command mouse-appearance-menu > at that spot is undefined > > it's hard to do much better: the S-mouse-1 event is eaten by > `mouse-appearance-menu` but it's basically impossible to determine > that automatically. > > And if you want to "not show undefined sequences", does that mean we > don't say anything at all for `C-h k M-_` rather than "M-_ is undefined"? > How 'bout `C-h c M-S-double-mouse-1` which with my code says (courtesy > copy-next-command-output (!)): > > (translated from ) at that spot is undefined > (translated from ) is undefined > > We can probably come up with some heuristic to keep "at least one line > of output" or something, but I think it's more useful for the user to > report all the events and their binding or lack thereof since we don't > really know what the user is looking for. I'd prefer the "undefined" lines to appear only if none of the possible interpretations is bound to a command, yes.