From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31318: emacs-26 fns-tests-collate-sort failure on glibc 2.27 Date: Mon, 30 Apr 2018 22:50:29 +0300 Message-ID: <83vac8qxru.fsf@gnu.org> References: <1cf43452-0e5f-f1f6-6368-d975fd273ce7@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1525117750 9899 195.159.176.226 (30 Apr 2018 19:49:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 30 Apr 2018 19:49:10 +0000 (UTC) Cc: 31318@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 30 21:49:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDEnJ-0002Qw-QK for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Apr 2018 21:49:05 +0200 Original-Received: from localhost ([::1]:33111 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDEpQ-00071L-MI for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Apr 2018 15:51:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDEpF-0006zc-SM for bug-gnu-emacs@gnu.org; Mon, 30 Apr 2018 15:51:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDEpC-0006nh-0r for bug-gnu-emacs@gnu.org; Mon, 30 Apr 2018 15:51:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36365) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDEpB-0006nW-TT for bug-gnu-emacs@gnu.org; Mon, 30 Apr 2018 15:51:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fDEpB-0007Ed-Ma for bug-gnu-emacs@gnu.org; Mon, 30 Apr 2018 15:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Apr 2018 19:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31318 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 31318-submit@debbugs.gnu.org id=B31318.152511785527799 (code B ref 31318); Mon, 30 Apr 2018 19:51:01 +0000 Original-Received: (at 31318) by debbugs.gnu.org; 30 Apr 2018 19:50:55 +0000 Original-Received: from localhost ([127.0.0.1]:44262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDEp5-0007EJ-6g for submit@debbugs.gnu.org; Mon, 30 Apr 2018 15:50:55 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fDEp3-0007E0-9P for 31318@debbugs.gnu.org; Mon, 30 Apr 2018 15:50:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDEou-0006ac-4e for 31318@debbugs.gnu.org; Mon, 30 Apr 2018 15:50:48 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDEou-0006aR-0X; Mon, 30 Apr 2018 15:50:44 -0400 Original-Received: from [176.228.60.248] (port=1869 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fDEos-0003av-TL; Mon, 30 Apr 2018 15:50:43 -0400 In-reply-to: <1cf43452-0e5f-f1f6-6368-d975fd273ce7@cs.ucla.edu> (message from Paul Eggert on Mon, 30 Apr 2018 10:36:31 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145878 Archived-At: > From: Paul Eggert > Date: Mon, 30 Apr 2018 10:36:31 -0700 > > I upgraded to Fedora 28 beta over the weekend (Fedora 28 is scheduled > for release next week) and ran into one test case failure on the > emacs-26 branch: fns-tests-collate-sort fails (test/src/fns-tests.log is > attached). Looking into the test, it appears that the test is making > unportable assumptions about strcoll behavior in non-POSIX locales, an > assumption that is not true of glibc 2.27 as shipped in Fedora 28. Really? So you are saying that 'ls' now sorts differently in UTF-8 locales on Fedora 28? That is, it no longer ignores punctuation in file names? Doesn't that cause user outcry? > - ;; In a language specific locale, collation order is different. > - (should (string-collate-lessp > - "xyzzy" "XYZZY" > - (if (eq system-type 'windows-nt) "enu_USA" "en_US.UTF-8"))) > + ;; In a language specific locale on MS-Windows, collation order is different. > + (when (eq system-type 'windows-nt) > + (should (string-collate-lessp "xyzzy" "XYZZY" "en_US.UTF-8"))) This is backwards: Windows needs enu_USA, not en_US.UTF-8 (which is not supported on Windows). > - ;; Diacritics are sorted between similar letters for other locales. > - (should > - (equal > - (sort '("Ævar" "Agustín" "Adrian" "Eli") > - (lambda (a b) > - (let ((w32-collate-ignore-punctuation t)) > - (string-collate-lessp > - a b (if (eq system-type 'windows-nt) "enu_USA" "en_US.UTF-8"))))) > - '("Adrian" "Ævar" "Agustín" "Eli")))) > + ;; Diacritics are sorted between similar letters for other locales, > + ;; on MS-Windows systems. > + (when (eq system-type 'windows-nt) > + (should > + (equal > + (sort '("Ævar" "Agustín" "Adrian" "Eli") > + (lambda (a b) > + (let ((w32-collate-ignore-punctuation t)) > + (string-collate-lessp > + a b "enu_USA")))) > + '("Adrian" "Ævar" "Agustín" "Eli"))))) So none of this now works on Fedora 28? That's too bad, don't you think? Why did they change the collation order?