From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 31318@debbugs.gnu.org
Subject: bug#31318: emacs-26 fns-tests-collate-sort failure on glibc 2.27
Date: Mon, 30 Apr 2018 22:50:29 +0300 [thread overview]
Message-ID: <83vac8qxru.fsf@gnu.org> (raw)
In-Reply-To: <1cf43452-0e5f-f1f6-6368-d975fd273ce7@cs.ucla.edu> (message from Paul Eggert on Mon, 30 Apr 2018 10:36:31 -0700)
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Mon, 30 Apr 2018 10:36:31 -0700
>
> I upgraded to Fedora 28 beta over the weekend (Fedora 28 is scheduled
> for release next week) and ran into one test case failure on the
> emacs-26 branch: fns-tests-collate-sort fails (test/src/fns-tests.log is
> attached). Looking into the test, it appears that the test is making
> unportable assumptions about strcoll behavior in non-POSIX locales, an
> assumption that is not true of glibc 2.27 as shipped in Fedora 28.
Really? So you are saying that 'ls' now sorts differently in UTF-8
locales on Fedora 28? That is, it no longer ignores punctuation in
file names? Doesn't that cause user outcry?
> - ;; In a language specific locale, collation order is different.
> - (should (string-collate-lessp
> - "xyzzy" "XYZZY"
> - (if (eq system-type 'windows-nt) "enu_USA" "en_US.UTF-8")))
> + ;; In a language specific locale on MS-Windows, collation order is different.
> + (when (eq system-type 'windows-nt)
> + (should (string-collate-lessp "xyzzy" "XYZZY" "en_US.UTF-8")))
This is backwards: Windows needs enu_USA, not en_US.UTF-8 (which is
not supported on Windows).
> - ;; Diacritics are sorted between similar letters for other locales.
> - (should
> - (equal
> - (sort '("Ævar" "Agustín" "Adrian" "Eli")
> - (lambda (a b)
> - (let ((w32-collate-ignore-punctuation t))
> - (string-collate-lessp
> - a b (if (eq system-type 'windows-nt) "enu_USA" "en_US.UTF-8")))))
> - '("Adrian" "Ævar" "Agustín" "Eli"))))
> + ;; Diacritics are sorted between similar letters for other locales,
> + ;; on MS-Windows systems.
> + (when (eq system-type 'windows-nt)
> + (should
> + (equal
> + (sort '("Ævar" "Agustín" "Adrian" "Eli")
> + (lambda (a b)
> + (let ((w32-collate-ignore-punctuation t))
> + (string-collate-lessp
> + a b "enu_USA"))))
> + '("Adrian" "Ævar" "Agustín" "Eli")))))
So none of this now works on Fedora 28? That's too bad, don't you
think? Why did they change the collation order?
next prev parent reply other threads:[~2018-04-30 19:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 17:36 bug#31318: emacs-26 fns-tests-collate-sort failure on glibc 2.27 Paul Eggert
2018-04-30 19:50 ` Eli Zaretskii [this message]
2018-05-01 0:39 ` Paul Eggert
2018-05-01 16:11 ` Eli Zaretskii
2018-05-01 16:31 ` Paul Eggert
2018-05-01 16:49 ` Eli Zaretskii
2019-06-18 23:52 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83vac8qxru.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=31318@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.