From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31929: [PATCH] Install emacs-module.h (Bug#31929) Date: Fri, 21 Sep 2018 16:45:34 +0300 Message-ID: <83va6zc6bl.fsf@gnu.org> References: <20180921132748.95945-1-phst@google.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1537537517 29069 195.159.176.226 (21 Sep 2018 13:45:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 21 Sep 2018 13:45:17 +0000 (UTC) Cc: phst@google.com, 31929@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 21 15:45:13 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3Lk8-0007On-JQ for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Sep 2018 15:45:12 +0200 Original-Received: from localhost ([::1]:55785 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3LmD-00034F-J8 for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Sep 2018 09:47:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3Llx-00032a-Oy for bug-gnu-emacs@gnu.org; Fri, 21 Sep 2018 09:47:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g3Llu-0004L6-J2 for bug-gnu-emacs@gnu.org; Fri, 21 Sep 2018 09:47:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43493) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g3Llu-0004Kv-Df for bug-gnu-emacs@gnu.org; Fri, 21 Sep 2018 09:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g3Llu-0000Yu-9U for bug-gnu-emacs@gnu.org; Fri, 21 Sep 2018 09:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Sep 2018 13:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31929 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31929-submit@debbugs.gnu.org id=B31929.15375375632084 (code B ref 31929); Fri, 21 Sep 2018 13:47:02 +0000 Original-Received: (at 31929) by debbugs.gnu.org; 21 Sep 2018 13:46:03 +0000 Original-Received: from localhost ([127.0.0.1]:47751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3Lkw-0000XR-Vd for submit@debbugs.gnu.org; Fri, 21 Sep 2018 09:46:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g3Lku-0000Ww-VS for 31929@debbugs.gnu.org; Fri, 21 Sep 2018 09:46:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g3Lko-0002zs-Uh for 31929@debbugs.gnu.org; Fri, 21 Sep 2018 09:45:55 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36208) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3Lkk-0002sk-N1; Fri, 21 Sep 2018 09:45:50 -0400 Original-Received: from [176.228.60.248] (port=1886 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g3Lkk-0006oM-41; Fri, 21 Sep 2018 09:45:50 -0400 In-reply-to: <20180921132748.95945-1-phst@google.com> (message from Philipp Stephani on Fri, 21 Sep 2018 15:27:48 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150523 Archived-At: > From: Philipp Stephani > Date: Fri, 21 Sep 2018 15:27:48 +0200 > Cc: Philipp Stephani > > + $(MKDIR_P) -m 0755 $(includedir) > + $(INSTALL_DATA) src/emacs-module.h $(includedir)/emacs-module.h Thanks. I wonder whether we should install in $(includedir)/emacs. It sounds rude to me to invade the top-level include directory; other packages install into package-specific subdirectories. If you agree, we may need to change mod-test.c and perhaps also the place where we keep emacs-module.h in the Emacs tree. We should also think what will happen when we change the interface in some backward-incompatible way: how do we allow end-users to compile modules for several Emacs versions on the same system? does that require a new version of the header, or can we provide a header that will work with any Emacs version?