From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: phst@google.com, 31929@debbugs.gnu.org
Subject: bug#31929: [PATCH] Install emacs-module.h (Bug#31929)
Date: Fri, 21 Sep 2018 16:45:34 +0300 [thread overview]
Message-ID: <83va6zc6bl.fsf@gnu.org> (raw)
In-Reply-To: <20180921132748.95945-1-phst@google.com> (message from Philipp Stephani on Fri, 21 Sep 2018 15:27:48 +0200)
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Fri, 21 Sep 2018 15:27:48 +0200
> Cc: Philipp Stephani <phst@google.com>
>
> + $(MKDIR_P) -m 0755 $(includedir)
> + $(INSTALL_DATA) src/emacs-module.h $(includedir)/emacs-module.h
Thanks. I wonder whether we should install in $(includedir)/emacs.
It sounds rude to me to invade the top-level include directory; other
packages install into package-specific subdirectories.
If you agree, we may need to change mod-test.c and perhaps also the
place where we keep emacs-module.h in the Emacs tree.
We should also think what will happen when we change the interface in
some backward-incompatible way: how do we allow end-users to compile
modules for several Emacs versions on the same system? does that
require a new version of the header, or can we provide a header that
will work with any Emacs version?
next prev parent reply other threads:[~2018-09-21 13:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 16:04 bug#31929: 27.0.50; Have make install copy the emacs-module.h to the destination install dir Kaushal Modi
2018-09-21 13:27 ` bug#31929: [PATCH] Install emacs-module.h (Bug#31929) Philipp Stephani
2018-09-21 13:45 ` Eli Zaretskii [this message]
2018-09-21 16:56 ` Philipp Stephani
2018-09-21 15:36 ` Glenn Morris
2018-09-21 16:57 ` Philipp Stephani
2018-10-03 20:02 ` Philipp Stephani
2018-10-03 20:51 ` Glenn Morris
2018-10-06 10:19 ` Eli Zaretskii
2018-10-15 20:04 ` Glenn Morris
2018-10-16 2:29 ` Eli Zaretskii
2018-10-04 16:16 ` Eli Zaretskii
[not found] ` <handler.31929.D31929.153859694712784.notifdone@debbugs.gnu.org>
2018-10-03 20:27 ` bug#31929: closed (Re: [PATCH] Install emacs-module.h (Bug#31929)) Kaushal Modi
2018-10-03 20:49 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83va6zc6bl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=31929@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.