From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums Date: Fri, 26 Oct 2018 20:33:23 +0300 Message-ID: <83va5ooboc.fsf@gnu.org> References: <83bm7hozav.fsf@gnu.org> <83zhv0oink.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1540575099 26004 195.159.176.226 (26 Oct 2018 17:31:39 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 26 Oct 2018 17:31:39 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 26 19:31:35 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gG5xN-0006c0-Ll for ged-emacs-devel@m.gmane.org; Fri, 26 Oct 2018 19:31:33 +0200 Original-Received: from localhost ([::1]:33538 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG5zU-0004UW-89 for ged-emacs-devel@m.gmane.org; Fri, 26 Oct 2018 13:33:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG5zN-0004S0-GD for emacs-devel@gnu.org; Fri, 26 Oct 2018 13:33:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gG5zK-0004fu-8Z for emacs-devel@gnu.org; Fri, 26 Oct 2018 13:33:37 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35574) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG5zB-0004ap-A2; Fri, 26 Oct 2018 13:33:27 -0400 Original-Received: from [176.228.60.248] (port=2407 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gG5z7-0006Yr-6v; Fri, 26 Oct 2018 13:33:25 -0400 In-reply-to: (message from Stefan Monnier on Fri, 26 Oct 2018 12:04:11 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230720 Archived-At: > From: Stefan Monnier > Date: Fri, 26 Oct 2018 12:04:11 -0400 > > >> > Stefan, this change needs a suitable change in the docs (both the doc > >> > string and the ELisp manual): they still claim integers are compared > >> > using 'equal', which AFAIU is now inaccurate. > >> AFAIK using `eql` gives the same result as comparing with `equal`: > >> It's just an internal optimization that is transparent to the user. > > That's so, but I find documentation that explicitly calls out 'equal' > > misleading when the code actually invokes 'eql' instead. > > I don't understand why you feel that way. "Feel"? The text refers to 'equal' explicitly, so it's not a feeling, it's a fact. > Would you feel the same if `pcase` always used `equal` and the > optimization to `eql` were performed in the byte-compiler instead? I don't know, and it's not really relevant, is it? > > Maybe we should make the text less explicit then? > > I can't think of any way to make the text less explicit without making > it either too vague or a lot more verbose. How about this: ‘KEYWORD’ ‘INTEGER’ ‘STRING’ Matches if EXPVAL is equal to the literal object. The equality predicate depends on the type of the object; e.g., symbols are compared using 'eq', and strings using 'equal'.