From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: face-remapping-alist can not override internal-border face?
Date: Sat, 09 Mar 2019 19:51:02 +0200
Message-ID: <83va0s6int.fsf@gnu.org>
References: <3a1726b0.64ab.1695b90bb85.Coremail.tumashu@163.com>
	<83wol9ai1f.fsf@gnu.org>
	<6b96411a.e495.1695e1a9d58.Coremail.tumashu@163.com>
	<83zhq46k97.fsf@gnu.org>
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="194925"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: tumashu@163.com
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 09 18:51:45 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1h2g8L-000oak-Id
	for ged-emacs-devel@m.gmane.org; Sat, 09 Mar 2019 18:51:41 +0100
Original-Received: from localhost ([127.0.0.1]:33670 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1h2g8K-0003Zb-LU
	for ged-emacs-devel@m.gmane.org; Sat, 09 Mar 2019 12:51:40 -0500
Original-Received: from eggs.gnu.org ([209.51.188.92]:49620)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1h2g8E-0003ZL-Vn
	for emacs-devel@gnu.org; Sat, 09 Mar 2019 12:51:35 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33341)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1h2g8D-0001ou-Me; Sat, 09 Mar 2019 12:51:33 -0500
Original-Received: from [176.228.60.248] (port=3618 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1h2g8B-0003ED-3H; Sat, 09 Mar 2019 12:51:33 -0500
In-reply-to: <83zhq46k97.fsf@gnu.org> (message from Eli Zaretskii on Sat, 09
	Mar 2019 19:16:36 +0200)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:233983
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/233983>

> Date: Sat, 09 Mar 2019 19:16:36 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
> You are right.  I see that when we draw the border, we don't consult
> face-remapping-alist.  But I'm not sure we should, because
> face-remapping-alist can be buffer-local (and makes most sense when
> it's buffer-local), whereas the internal-border face affects the
> entire frame.

But I decided to fix this anyway, just don't expect this to do
something sensible if you make face-remapping-alist buffer-local.